Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1104543006: Style cleanups in Autofill for greater code clarity. (Closed)

Created:
5 years, 8 months ago by Evan Stade
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Style cleanups in Autofill for greater code clarity. No behavioral change. BUG=none Committed: https://crrev.com/950d0c463019b7081abd74807aab4b2b8e05e39e Cr-Commit-Position: refs/heads/master@{#326735}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M components/autofill/core/browser/autocomplete_history_manager.cc View 1 1 chunk +6 lines, -10 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/form_structure.cc View 1 1 chunk +8 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
https://codereview.chromium.org/1104543006/diff/1/components/autofill/core/browser/form_structure.cc File components/autofill/core/browser/form_structure.cc (right): https://codereview.chromium.org/1104543006/diff/1/components/autofill/core/browser/form_structure.cc#newcode384 components/autofill/core/browser/form_structure.cc:384: base::IntToString16(++unique_names[field.name]); default initializer and all that
5 years, 8 months ago (2015-04-22 22:01:33 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-22 22:05:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104543006/20001
5 years, 8 months ago (2015-04-24 02:28:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 03:25:12 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 03:26:10 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/950d0c463019b7081abd74807aab4b2b8e05e39e
Cr-Commit-Position: refs/heads/master@{#326735}

Powered by Google App Engine
This is Rietveld 408576698