Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Issue 1104543005: Update {virtual,override} to follow C++11 style in sync. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in sync. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/7a69aba4fdece17645148f37ad2582174aa64c97 Cr-Commit-Position: refs/heads/master@{#326541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M sync/internal_api/sync_backup_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
maniscalco@ -- please review
5 years, 8 months ago (2015-04-23 04:06:20 UTC) #2
maniscalco
lgtm
5 years, 8 months ago (2015-04-23 15:22:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104543005/1
5 years, 8 months ago (2015-04-23 16:35:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 16:39:25 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 16:40:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a69aba4fdece17645148f37ad2582174aa64c97
Cr-Commit-Position: refs/heads/master@{#326541}

Powered by Google App Engine
This is Rietveld 408576698