Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: scripts/slave/recipe_modules/amp/api.py

Issue 1104533002: Add recipe for split AMP/local CQ. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Parent builder Android Builder (dbg) and expectation changes. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/amp/api.py
diff --git a/scripts/slave/recipe_modules/amp/api.py b/scripts/slave/recipe_modules/amp/api.py
index 71dd369fb6c223725f5aaf952f2a9981edcb43c8..5251494d33212af34662add10d93286d64cbadcb 100644
--- a/scripts/slave/recipe_modules/amp/api.py
+++ b/scripts/slave/recipe_modules/amp/api.py
@@ -238,15 +238,11 @@ class AmpApi(recipe_api.RecipeApi):
Returns:
A list of command-line arguments as strings.
"""
- if not api_address:
- raise self.m.step.StepFailure('api_address not specified')
- if not api_port:
- raise self.m.step.StepFailure('api_port not specified')
- if not api_protocol:
- raise self.m.step.StepFailure('api_protocol not specified')
- if device_minimum_os and device_os:
- raise self.m.step.StepFailure(
- 'cannot specify both device_minimum_os and device_os')
+ assert api_address, 'api_address not specified'
+ assert api_port, 'api_port not specified'
+ assert api_protocol, 'api_protocol not specified'
+ assert not (device_minimum_os and device_os), (
+ 'cannot specify both device_minimum_os and device_os')
amp_args = [
'--enable-platform-mode',

Powered by Google App Engine
This is Rietveld 408576698