scripts/slave/recipe_modules/chromium/example.py - Issue 1104533002: Add recipe for split AMP/local CQ.

Side by Side Diff: scripts/slave/recipe_modules/chromium/example.py

Issue 1104533002: Add recipe for split AMP/local CQ. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Pass the correct arguments to AMPGTestTest Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « scripts/slave/recipe_modules/chromium/chromium_fyi.py ('k') | scripts/slave/recipe_modules/chromium/example.expected/amp_split_recipe.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 DEPS = [	5 DEPS = [

	6 'amp',

6 'chromium',	7 'chromium',

	8 'chromium_android',

7 'chromium_tests',	9 'chromium_tests',

	10 'json',

	11 'path',

8 'properties',	12 'properties',

	13 'step',

	14 'test_utils'

9 ]	15 ]

10	16

11 def GenSteps(api):	17 def GenSteps(api):

12 mastername = api.properties.get('mastername')	18 mastername = api.properties.get('mastername')

13 buildername = api.properties.get('buildername')	19 buildername = api.properties.get('buildername')

14	20

15 api.chromium_tests.configure_build(mastername, buildername)	21 api.chromium_tests.configure_build(mastername, buildername)

16 update_step, master_dict, test_spec = \	22 update_step, master_dict, test_spec = \

17 api.chromium_tests.prepare_checkout(mastername, buildername)	23 api.chromium_tests.prepare_checkout(mastername, buildername)

18 #api.chromium_tests.compile(mastername, buildername, update_step, master_dict,	24 #api.chromium_tests.compile(mastername, buildername, update_step, master_dict,

19 # test_spec, out_dir='/tmp')	25 # test_spec, out_dir='/tmp')

20 api.chromium.compile(targets=['All'], out_dir='/tmp')	26 api.chromium.compile(targets=['All'], out_dir='/tmp')

	27 tests = api.chromium_tests.tests_for_builder(

	28 mastername, buildername, update_step, master_dict)

	29

	30 for test in tests:

	31 test.pre_run(api, '')
	navabi 2015/06/05 01:36:22 I don't know why I keep getting the recipe_simulat I don't know why I keep getting the recipe_simulation_test.py failure below: Trained 2041 tests in 18.217s (ran 2041 tests) Coverage Report Stmts Miss Cover Missing --------------------------------------------------------------------------------------------------------------------------------------------- /usr/local/google/code/buildbot/build/scripts/slave/recipe_modules/chromium/steps 571 7 99% 660-667, 674-687 --------------------------------------------------------------------------------------------------------------------------------------------- TOTAL 16558 7 99% FATAL: Test coverage is not at 100%. The lines 660-667 correspond to the pre_run function in AMPGTestTest, and here I'm calling pre_run. (Note: Before I had the steps the chromium recipes performs, but I was seeing this error, so I made an explicit call to pre_run and still fails for coverage of those lines).
	32

21	33

22 def GenTests(api):	34 def GenTests(api):

23 yield api.test('basic_out_dir') + api.properties(	35 yield api.test('basic_out_dir') + api.properties(

24 mastername='chromium.linux',	36 mastername='chromium.linux',

25 buildername='Android Builder (dbg)',	37 buildername='Android Builder (dbg)',

26 slavename='build1-a1',	38 slavename='build1-a1',

27 buildnumber='77457',	39 buildnumber='77457',

28 )	40 )

	41

	42 yield api.test('amp_split_recipe') + api.properties(

	43 mastername='chromium.fyi',

	44 buildername='Android Tests (amp split)',

	45 slavename='build1-a1',

	46 buildnumber='77457',

	47 parent_build_archive_url='gs://test-domain/test-archive.zip'

	48 )

OLD	NEW