Omnibox: Remove Hint Text Code

chrome/browser/ui/omnibox/omnibox_view.cc

Index: chrome/browser/ui/omnibox/omnibox_view.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view.cc b/chrome/browser/ui/omnibox/omnibox_view.cc
index f66cff677cc2366ade5188bce373d1f8d2f4f154..833cdfa7aa96a404c33c1b2a0acba7cf5ef0b944 100644
--- a/chrome/browser/ui/omnibox/omnibox_view.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view.cc
@@ -115,31 +115,6 @@ int OmniboxView::GetIcon() const {
   return (id == IDR_OMNIBOX_HTTP) ? IDR_LOCATION_BAR_HTTP : id;
 }
 
-base::string16 OmniboxView::GetHintText() const {
-  // If the user is in keyword mode (the "Search <some site>:" chip is showing)
-  // then it doesn't make sense to show the "Search <default search engine>"
-  // hint text.
-  if (model_->is_keyword_selected())
-    return base::string16();
-
-  // Attempt to determine the default search provider and use that in the hint
-  // text.
-  TemplateURLService* template_url_service =
-      TemplateURLServiceFactory::GetForProfile(model_->profile());
-  if (template_url_service) {
-    TemplateURL* template_url =
-        template_url_service->GetDefaultSearchProvider();
-    if (template_url)
-      return l10n_util::GetStringFUTF16(
-          IDS_OMNIBOX_EMPTY_HINT_WITH_DEFAULT_SEARCH_PROVIDER,

[Peter Kasting, 2015/04/23 00:52:49]

I don't think this string can be removed from the local NTP source, but I'd
change the name of the resource to IDS_EMPTY_SEARCH_BOX_HINT or something.

[Mark P, 2015/04/23 21:12:41]

Replaced OMNIBOX WITH SEARCH_BOX on this string.

[Peter Kasting, 2015/04/23 21:16:59]

OK.  I think that leaves too verbose of a name ("WITH_DEFAULT_SEARCH_PROVIDER"
is no longer needed for disambiguation and just seems confusing), but I don't
care much.

[Mark P, 2015/04/23 21:20:02]

Done.

-          template_url->AdjustedShortNameForLocaleDirection());
-  }
-
-  // Otherwise return a hint based on there being no default search provider.
-  return l10n_util::GetStringUTF16(
-      IDS_OMNIBOX_EMPTY_HINT_NO_DEFAULT_SEARCH_PROVIDER);

[Peter Kasting, 2015/04/23 00:52:49]

This string is now unused and should be removed.

[Mark P, 2015/04/23 21:12:41]

Done.

-}
-
 void OmniboxView::SetUserText(const base::string16& text) {
   SetUserText(text, text, true);
 }