added test to test case converting with nonASCII

added test to test case converting with nonASCII

Tested case conversion with some nonascii utf
chars. Also some which should not be changed.
Test also Turkish dotless I with different locales.

Committed: https://crrev.com/fb23d0eb03af465686f686145e184049a0b4d2e2
Cr-Commit-Position: refs/heads/master@{#330486}

[olli.syrjala, 2015-04-22 12:10:16]

olli.syrjala@intel.com changed reviewers:
+ jshin@chromium.org

[olli.syrjala, 2015-04-22 12:10:38]

Could you review?

[olli.syrjala, 2015-04-27 06:42:03]

Could you review?

[jungshik at Google, 2015-04-27 18:25:51]

Sorry for missing this. See comments below.

https://codereview.chromium.org/1104483002/diff/1/base/i18n/case_conversion_u...
File base/i18n/case_conversion_unittest.cc (right):

https://codereview.chromium.org/1104483002/diff/1/base/i18n/case_conversion_u...
base/i18n/case_conversion_unittest.cc:26: string16 mixed(UTF8ToUTF16(u8"ÄÖäö Ïï
÷%¤#*^`@£$‰‚~ ἇἏ Ḁḁ"));
MSVC does not support 'u8', yet, IIRC. It cannot even compile any source files
with non-ASCII byte sequences on CJK Windows if they happen to be valid in CJK
Windows code page. 

It's very unfortunate, but you have to use hex-escape here.

https://codereview.chromium.org/1104483002/diff/1/base/i18n/case_conversion_u...
base/i18n/case_conversion_unittest.cc:27: const string16
expected_lower(UTF8ToUTF16(u8"äöäö ïï ÷%¤#*^`@£$‰‚~ ἇἇ ḁḁ"));
Add a test with Turkish dotless i and try case conversion in both Turkish locale
and non-Turkish locale. You can do that by setting the ICU's default locale.
There are other tests that do that.

[olli.syrjala, 2015-05-06 08:08:36]

Thanks for comments, they are now implemented

[olli.syrjala, 2015-05-11 11:58:52]

Could you re-review?

[jungshik at Google, 2015-05-12 20:30:38]

Thanks. Pls, address my review comment below.

https://codereview.chromium.org/1104483002/diff/20001/base/i18n/case_conversi...
File base/i18n/case_conversion_unittest.cc (right):

https://codereview.chromium.org/1104483002/diff/20001/base/i18n/case_conversi...
base/i18n/case_conversion_unittest.cc:55: i18n::SetICUDefaultLocale("tr");
You'd better save the original ICU locale and restore it after you're done.

[olli.syrjala, 2015-05-13 07:31:25]

done, now it should be ready to commit? 

restoring is missing in many other tests as well.

[jungshik at Google, 2015-05-13 22:26:19]

LGTM Thanks.

On 2015/05/13 07:31:25, olli.syrjala wrote:
> done, now it should be ready to commit? 
> 
> restoring is missing in many other tests as well.

 

We have to fix them, too :-)

[olli.syrjala, 2015-05-19 06:15:10]

The CQ bit was checked by olli.syrjala@intel.com

[commit-bot: I haz the power, 2015-05-19 06:15:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104483002/60001

[commit-bot: I haz the power, 2015-05-19 06:51:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-19 06:51:57]

Patchset 4 (id:??) landed as
https://crrev.com/fb23d0eb03af465686f686145e184049a0b4d2e2
Cr-Commit-Position: refs/heads/master@{#330486}