chrome/browser/search_engines/template_url_service_android.cc - Issue 1104473002: Make the Location is Allowed link take the Geo Header into account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/template_url_service_android.cc

Issue 1104473002: Make the Location is Allowed link take the Geo Header into account. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search_engines/template_url_service_android.cc

diff --git a/chrome/browser/search_engines/template_url_service_android.cc b/chrome/browser/search_engines/template_url_service_android.cc

index 7b64168fc9f6388e58c970dfd6ac0fb85efb5cb4..ec59259746309745e1505452e2196b8b54a8d36d 100644

--- a/chrome/browser/search_engines/template_url_service_android.cc

+++ b/chrome/browser/search_engines/template_url_service_android.cc

@@ -253,7 +253,7 @@ TemplateUrlServiceAndroid::GetSearchEngineUrlFromTemplateUrl(

TemplateURL* template_url = template_url_service_->GetTemplateURLs()[index];

std::string url(template_url->url_ref().ReplaceSearchTerms(

TemplateURLRef::SearchTermsArgs(

- base::string16()), SearchTermsData(), nullptr));

+ base::ASCIIToUTF16("query")), SearchTermsData(), nullptr));

return base::android::ConvertUTF8ToJavaString(env, url);

}

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java ('k') | no next file » | no next file with comments »