Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1104443002: Add enable_media_router check to GN based grit targets. (Closed)

Created:
5 years, 8 months ago by apacible
Modified:
5 years, 8 months ago
Reviewers:
cjhopman, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add enable_media_router check to GN based grit targets. Originally, <if expr="enable_media_router"> was not picked up by a .grd file. I traced that to grit_rule.gni and added a check there. Committed: https://crrev.com/2be1ebd65b769821ad36e6cff2d47bda574c00bb Cr-Commit-Position: refs/heads/master@{#326598}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
apacible
PTAL, thanks!
5 years, 8 months ago (2015-04-22 17:26:10 UTC) #4
apacible
+cjhopman
5 years, 8 months ago (2015-04-23 18:07:02 UTC) #6
cjhopman
lgtm
5 years, 8 months ago (2015-04-23 18:08:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104443002/40001
5 years, 8 months ago (2015-04-23 18:10:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 8 months ago (2015-04-23 18:57:20 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 18:58:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2be1ebd65b769821ad36e6cff2d47bda574c00bb
Cr-Commit-Position: refs/heads/master@{#326598}

Powered by Google App Engine
This is Rietveld 408576698