Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1104423005: Revert of [Sync] Erase sync DB when corrupted (Closed)

Created:
5 years, 7 months ago by vkuzkokov
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Erase sync DB when corrupted (patchset #4 id:60001 of https://codereview.chromium.org/1082893003/) Reason for revert: Test fails on Win7 bots. see crbug.com/481895 Original issue's description: > [Sync] Erase sync DB when corrupted > > Directory now registers to be notified of catastrophic sync DB errors. > Upon notification, Directory triggers an unrecoverable sync error which > causes ProfileSyncService to delete the sync DB. > > Add integration test that verifies the sync DB is deleted when DB > corruption is detected. > > Remove unused member variable allow_failure_for_test_ from > DirectoryBackingStore. > > Add MockUnrecoverableErrorHandler to assist in writing tests for > Directory. > > BUG=470993 > > Committed: https://crrev.com/90a7f8d3e3b3a2aac43e71a93eac2731f084945c > Cr-Commit-Position: refs/heads/master@{#327120} TBR=zea@chromium.org,pvalenzuela@chromium.org,maniscalco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=470993 Committed: https://crrev.com/6d60180f3ca3f9289d37b27e77f90d97db488f7c Cr-Commit-Position: refs/heads/master@{#327264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -267 lines) Patch
M chrome/browser/sync/test/integration/single_client_directory_sync_test.cc View 3 chunks +0 lines, -82 lines 0 comments Download
M sync/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M sync/sync_tests.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M sync/syncable/directory.h View 3 chunks +0 lines, -7 lines 0 comments Download
M sync/syncable/directory.cc View 3 chunks +3 lines, -15 lines 0 comments Download
M sync/syncable/directory_backing_store_unittest.cc View 4 chunks +23 lines, -8 lines 0 comments Download
M sync/syncable/directory_unittest.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M sync/syncable/on_disk_directory_backing_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/on_disk_directory_backing_store.cc View 1 chunk +3 lines, -2 lines 0 comments Download
D sync/test/directory_backing_store_corruption_testing.h View 1 chunk +0 lines, -27 lines 0 comments Download
D sync/test/directory_backing_store_corruption_testing.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D sync/util/mock_unrecoverable_error_handler.h View 1 chunk +0 lines, -35 lines 0 comments Download
D sync/util/mock_unrecoverable_error_handler.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vkuzkokov
Created Revert of [Sync] Erase sync DB when corrupted
5 years, 7 months ago (2015-04-28 11:26:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104423005/1
5 years, 7 months ago (2015-04-28 11:26:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 11:27:44 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 11:28:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d60180f3ca3f9289d37b27e77f90d97db488f7c
Cr-Commit-Position: refs/heads/master@{#327264}

Powered by Google App Engine
This is Rietveld 408576698