Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1104413002: [tracing] Get rid of MemoryAllocatorAttributesTypeInfo (Closed)

Created:
5 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
nduca
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org, ssid, petrcermak
Base URL:
https://chromium.googlesource.com/chromium/src.git@simplif_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Get rid of MemoryAllocatorAttributesTypeInfo This is in preparation of crrev.com/1105143003 which simplifies the MemoryAllocatorDump attributes model with a more generic one. BUG=466141 Committed: https://crrev.com/61add08de1b39866f8dd4c946f131fbff035d8a8 Cr-Commit-Position: refs/heads/master@{#327272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -207 lines) Patch
M base/trace_event/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D base/trace_event/memory_allocator_attributes_type_info.h View 1 chunk +0 lines, -49 lines 0 comments Download
D base/trace_event/memory_allocator_attributes_type_info.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D base/trace_event/memory_allocator_attributes_type_info_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M base/trace_event/memory_allocator_dump.h View 2 chunks +0 lines, -5 lines 0 comments Download
M base/trace_event/memory_allocator_dump.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M base/trace_event/memory_dump_session_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Primiano Tucci (use gerrit)
PTAL, this is just removing files This is part of a series of 3 CLs ...
5 years, 8 months ago (2015-04-27 22:40:35 UTC) #2
nduca
lgtm
5 years, 8 months ago (2015-04-28 00:25:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104413002/1
5 years, 8 months ago (2015-04-28 08:06:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/65808) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 8 months ago (2015-04-28 08:15:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104413002/1
5 years, 7 months ago (2015-04-28 10:21:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 12:47:23 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 13:46:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61add08de1b39866f8dd4c946f131fbff035d8a8
Cr-Commit-Position: refs/heads/master@{#327272}

Powered by Google App Engine
This is Rietveld 408576698