Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs

Issue 11044024: Implement multi-core builds in MSVS (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs
diff --git a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs
index 57ea2537f0254d62f67aa145832b7379bc779fd4..be3a5ef568d0a1e40604b20be1feb475ee43ff3a 100644
--- a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs
+++ b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs
@@ -12,12 +12,12 @@ namespace NaCl.Build.CPPTasks
{
public const int s_CommandLineLength = 256;
- public static string Convert_Path_Windows_To_Posix(string path)
+ public static string ConvertPathWindowsToPosix(string path)
{
return path.Replace('\\', '/');
}
- public static string Convert_Path_Posix_To_Windows(string path)
+ public static string ConvertPathPosixToWindows(string path)
{
path = path.Replace('/', '\\');
// also make double backslashes a single slash
@@ -26,7 +26,7 @@ namespace NaCl.Build.CPPTasks
}
// replace GCC error are warning output to Visual Studio format to support going to source code from error output.
- public static string Convert_Output_GCC_to_VS(string line)
+ public static string ConvertGCCOutput(string line)
{
string result;
foreach (GCCRegexLineConverter converter in s_RegexConverters)
@@ -76,21 +76,21 @@ namespace NaCl.Build.CPPTasks
}
} // GCCRegexLineConverter
- private static readonly List<GCCRegexLineConverter> s_RegexConverters = new List<GCCRegexLineConverter>
+ private static readonly List<GCCRegexLineConverter> s_RegexConverters = new List<GCCRegexLineConverter>
{
- new GCCRegexLineConverter
+ new GCCRegexLineConverter
{
OutputExpression = new Regex(@"^\s*(.?.?[^:]*.*?):([1-9]\d*):([1-9]\d*):(.*$)"),
FilenameIdentifier = @"$1",
RemainderIdentifier = @"($2,$3):$4"
},
- new GCCRegexLineConverter
+ new GCCRegexLineConverter
{
OutputExpression = new Regex(@"^\s*(.?.?[^:]*.*?):([1-9]\d*):(.*$)"),
FilenameIdentifier = @"$1",
RemainderIdentifier = @"($2):$3"
},
- new GCCRegexLineConverter
+ new GCCRegexLineConverter
{
OutputExpression = new Regex(@"^\s*(.?.?[^:]*.*?):(.?.?[^:]*.*?):([1-9]\d*):(.*$)"),
FilenameIdentifier = @"$2",

Powered by Google App Engine
This is Rietveld 408576698