Added ability to list and delete hosts with GCD.

remoting/webapp/crd/js/host_list_api_gcd_impl.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * REST API for host-list management.
  */
 
 /** @suppress {duplicate} */
@@ skipping 40 matching lines @@
       }).
       then(function(/**remoting.gcd.RegistrationTicket*/ ticket) {
         return ticket.robotAccountAuthorizationCode;
       }).
       catch(function(error) {
         console.error('Error registering device with GCD: ' + error);
         throw new remoting.Error(remoting.Error.Tag.REGISTRATION_FAILED);
       }));
 };
 
 /** @override */

[Jamie, 2015/04/27 22:44:06]

@return {Promise<Array<remoting.Host>>}?

[John Williams, 2015/04/27 23:05:42]

I generally don't like to repeat the type declarations in an overridden method
since it's more stuff to keep in sync.  (There are cases where the compiler gets
confused unless you repeat the type declarations, but it doesn't seem to be a
problem here.)

 remoting.HostListApiGcdImpl.prototype.get = function() {
-  // TODO(jrw)
-  this.gcd_.listDevices();
-  return Promise.resolve([]);
+  return this.gcd_.listDevices().
+      then(function(devices) {
+        var hosts = [];
+        devices.forEach(function(device) {
+          try {
+            hosts.push(remoting.HostListApiGcdImpl.deviceToHost(device));
+          } catch (/** @type {*} */ error) {
+            console.warn('Invalid device spec:', error);
+          }
+        });
+        return hosts;
+      });
 };
 
 /** @override */
 remoting.HostListApiGcdImpl.prototype.put =
     function(hostId, hostName, hostPublicKey) {
   // TODO(jrw)
   throw new Error('Not implemented');
 };
 
 /** @override */
 remoting.HostListApiGcdImpl.prototype.remove = function(hostId) {
-  // TODO(jrw)
-  throw new Error('Not implemented');
+  var that = this;
+  return this.gcd_.listDevices(hostId).then(function(devices) {

[Jamie, 2015/04/27 22:44:06]

You're passing a hostId to a function expecting a name. It seems like "name"
means something different in GCD vs. CRD. Is that imposed by GCD, or are we free
to use id and name to mean the same things as they do in CRD?

[John Williams, 2015/04/27 23:05:42]

It's imposed by GCD.  We could use GCD's own "id" field, but doing so would
complicate interoperability with the legacy registry because GCD doesn't let you
assign your own IDs.  Using the "name" field seems reasonable to me, since GCD
has a separate "displayName" field for user-visible device names.

It might make sense to revisit this decision once we're fully migrated to GCD,
but as long as the registry exists I don't want to deviate too much from how the
registry does things.

+    var gcdId = null;
+    for (var i = 0; i < devices.length; i++) {
+      var device = devices[i];
+      if (device.name == hostId) {
+        gcdId = device.id;
+      }
+    }
+    if (gcdId == null) {
+      return false;
+    } else {
+      return that.gcd_.deleteDevice(gcdId);
+    }
+  });
+};
+
+/**
+ * @param {!Object} device
+ * @return {!remoting.Host}
+ */
+remoting.HostListApiGcdImpl.deviceToHost = function(device) {
+  var statusMap = {
+    'online': 'ONLINE',
+    'offline': 'OFFLINE'
+  };
+  var hostId = base.getStringAttr(device, 'name');
+  var host = new remoting.Host(hostId);
+  host.hostName = base.getStringAttr(device, 'displayName');
+  host.status = base.getStringAttr(
+      statusMap, base.getStringAttr(device, 'connectionStatus'));
+  var state = base.getObjectAttr(device, 'state', {});
+  host.publicKey = base.getStringAttr(state, 'publicKey');
+  host.jabberId = base.getStringAttr(state, 'jabberId', '');
+  host.hostVersion = base.getStringAttr(state, 'hostVersion', '');
+  var creationTimeMs = base.getNumberAttr(device, 'creationTimeMs', 0);
+  if (creationTimeMs) {
+    host.createdTime = new Date(creationTimeMs).toISOString();
+  }
+  var lastUpdateTimeMs = base.getNumberAttr(device, 'lastUpdateTimeMs', 0);
+  if (lastUpdateTimeMs) {
+    host.updatedTime = new Date(lastUpdateTimeMs).toISOString();
+  }
+  return host;
 };
 
 })();