Added ability to list and delete hosts with GCD.

Added ability to list and delete hosts with GCD.

BUG=471928
Committed: https://crrev.com/4f3a98748e1196f0bc6c63022f41deb0ea392f46
Cr-Commit-Position: refs/heads/master@{#327219}

[John Williams, 2015-04-27 21:45:47]

jrw@chromium.org changed reviewers:
+ jamiewalch@google.com

[Jamie, 2015-04-27 22:44:05]

jamiewalch@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2015-04-27 22:44:06]

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/gcd_...
File remoting/webapp/crd/js/gcd_client.js (right):

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/gcd_...
remoting/webapp/crd/js/gcd_client.js:210: * @param {string=} opt_nameSubstring
Please document this parameter.

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/host...
File remoting/webapp/crd/js/host_list_api_gcd_impl.js (right):

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api_gcd_impl.js:61: /** @override */
@return {Promise<Array<remoting.Host>>}?

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api_gcd_impl.js:87: return
this.gcd_.listDevices(hostId).then(function(devices) {
You're passing a hostId to a function expecting a name. It seems like "name"
means something different in GCD vs. CRD. Is that imposed by GCD, or are we free
to use id and name to mean the same things as they do in CRD?

[John Williams, 2015-04-27 23:05:42]

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/gcd_...
File remoting/webapp/crd/js/gcd_client.js (right):

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/gcd_...
remoting/webapp/crd/js/gcd_client.js:210: * @param {string=} opt_nameSubstring
On 2015/04/27 22:44:06, Jamie wrote:
> Please document this parameter.

Done.

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/host...
File remoting/webapp/crd/js/host_list_api_gcd_impl.js (right):

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api_gcd_impl.js:61: /** @override */
On 2015/04/27 22:44:06, Jamie wrote:
> @return {Promise<Array<remoting.Host>>}?

I generally don't like to repeat the type declarations in an overridden method
since it's more stuff to keep in sync.  (There are cases where the compiler gets
confused unless you repeat the type declarations, but it doesn't seem to be a
problem here.)

https://codereview.chromium.org/1104383002/diff/1/remoting/webapp/crd/js/host...
remoting/webapp/crd/js/host_list_api_gcd_impl.js:87: return
this.gcd_.listDevices(hostId).then(function(devices) {
On 2015/04/27 22:44:06, Jamie wrote:
> You're passing a hostId to a function expecting a name. It seems like "name"
> means something different in GCD vs. CRD. Is that imposed by GCD, or are we
free
> to use id and name to mean the same things as they do in CRD?

It's imposed by GCD.  We could use GCD's own "id" field, but doing so would
complicate interoperability with the legacy registry because GCD doesn't let you
assign your own IDs.  Using the "name" field seems reasonable to me, since GCD
has a separate "displayName" field for user-visible device names.

It might make sense to revisit this decision once we're fully migrated to GCD,
but as long as the registry exists I don't want to deviate too much from how the
registry does things.

[Jamie, 2015-04-27 23:26:48]

lgtm

[John Williams, 2015-04-28 01:10:02]

The CQ bit was checked by jrw@chromium.org

[commit-bot: I haz the power, 2015-04-28 01:10:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104383002/20001

[commit-bot: I haz the power, 2015-04-28 02:16:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-28 02:17:00]

Patchset 2 (id:??) landed as
https://crrev.com/4f3a98748e1196f0bc6c63022f41deb0ea392f46
Cr-Commit-Position: refs/heads/master@{#327219}