Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 1104333003: vs2015: Don't have posix error codes defined during libxml build (Closed)

Created:
5 years, 8 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-alloc-shim
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

vs2015: Don't have posix error codes defined during libxml build FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\cl.exe" /nologo /showIncludes /FC @obj\third_party\libxml\src\libxml.nanohttp.obj.rsp /c ..\..\third_party\libxml\src\nanohttp.c /Foobj\third_party\libxml\src\libxml.nanohttp.obj /Fdobj\third_party\libxml\libxml.c.pdb d:\src\cr2\src\third_party\libxml\src\include\wsockcompat.h(41): error C2220: warning treated as error - no 'object' file generated d:\src\cr2\src\third_party\libxml\src\include\wsockcompat.h(41): warning C4005: 'EWOULDBLOCK': macro redefinition ... etc. (I don't know why we have nanoftp.c and nanohttp.c being built, but that seems wrong too.) R=cpu@chromium.org BUG=440500 Committed: https://crrev.com/72ef46b64a7b8b6fef8ef81a4cf2959c119c9f4c Cr-Commit-Position: refs/heads/master@{#327440}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M third_party/libxml/README.chromium View 1 chunk +3 lines, -2 lines 0 comments Download
A third_party/libxml/patches/win32-no-posix-error-codes View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/libxml/src/libxml.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 8 months ago (2015-04-27 23:03:07 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-04-29 00:32:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104333003/20001
5 years, 7 months ago (2015-04-29 02:00:27 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-29 05:59:49 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 06:01:48 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72ef46b64a7b8b6fef8ef81a4cf2959c119c9f4c
Cr-Commit-Position: refs/heads/master@{#327440}

Powered by Google App Engine
This is Rietveld 408576698