Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1104313002: Allow paths to be resolved in the GN args file (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow paths to be resolved in the GN args file This uses the real settings object which contains the location of the source root for resolving "//..." paths. The use-case is to allow imports to be processed in the args file, which in turn allows one to assign a set of build arguments by reference. Committed: https://crrev.com/c2f498dd8cb63c49663b5f80aabf808b4fd1d1c4 Cr-Commit-Position: refs/heads/master@{#327131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M tools/gn/setup.h View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/gn/setup.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
5 years, 7 months ago (2015-04-27 19:22:21 UTC) #2
scottmg
lgtm
5 years, 7 months ago (2015-04-27 20:17:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104313002/1
5 years, 7 months ago (2015-04-27 20:26:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 21:31:11 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 21:32:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2f498dd8cb63c49663b5f80aabf808b4fd1d1c4
Cr-Commit-Position: refs/heads/master@{#327131}

Powered by Google App Engine
This is Rietveld 408576698