Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: utils/pub/io.dart

Issue 11043026: Don't warn on the absence of "lib" in the root package. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | utils/tests/pub/pub_install_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index 11e6361357ebd4728e9aeb316c0248a29e1dc1c1..b96ffcaf932ced0ea8669699b7e5dab83a7f3dca 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -353,7 +353,14 @@ Future<File> createPackageSymlink(String name, from, to,
if (exists) {
return createSymlink(from, to);
} else {
- printError('Warning: Package "$name" does not have a "lib" directory.');
+ // It's OK for the self link (i.e. the root package) to not have a lib
+ // directory since it may just be a leaf application that only has
+ // code in bin or web.
+ if (!isSelfLink) {
+ printError(
+ 'Warning: Package "$name" does not have a "lib" directory.');
+ }
+
return new Future.immediate(to);
}
});
« no previous file with comments | « no previous file | utils/tests/pub/pub_install_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698