Issue 11043015: Merge 158784 - Send OnModifyFile Notification when File Write completes successfully or fails but s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11043015: Merge 158784 - Send OnModifyFile Notification when File Write completes successfully or fails but s… (Closed)

Created:
8 years, 2 months ago by kinaba

Modified:
8 years, 2 months ago

Reviewers:
calvinlo

CC:
chromium-reviews, stevenjb+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, oshima+watch_chromium.org, tzik+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

More Reviews

Description

Merge 158784 - Send OnModifyFile Notification when File Write completes successfully or fails but something was written. e.g. partial write before failure. BUG=150060 Review URL: https://chromiumcodereview.appspot.com/10956064 TBR=calvinlo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159826

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -43 lines)			Patch
M	webkit/chromeos/fileapi/remote_file_system_operation.h	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/chromeos/fileapi/remote_file_system_operation.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/fileapi/file_writer_delegate.h	View	2 chunks	+16 lines, -2 lines	0 comments	Download
M	webkit/fileapi/file_writer_delegate.cc	View	4 chunks	+14 lines, -5 lines	0 comments	Download
M	webkit/fileapi/file_writer_delegate_unittest.cc	View	14 chunks	+26 lines, -28 lines	0 comments	Download
M	webkit/fileapi/local_file_system_operation.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	webkit/fileapi/local_file_system_operation.cc	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	webkit/fileapi/local_file_system_operation_write_unittest.cc	View	13 chunks	+35 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

calvinlo

On 2012/10/03 01:41:52, kinaba wrote: LGTM but I think you need Kinuko as an owner ...

8 years, 2 months ago (2012-10-03 04:11:32 UTC) #2

kinaba

8 years, 2 months ago (2012-10-03 04:15:06 UTC) #3

On 2012/10/03 04:11:32, calvinlo wrote:
> On 2012/10/03 01:41:52, kinaba wrote:
> 
> LGTM but I think you need Kinuko as an owner to approve for commit I think?

Thanks, this is a merging commit that usually don't need owner's check (since
your original CL got approved already).

Expand Messages | Collapse Messages