Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 11043004: Merge 157903 - Turn off animations for page actions and browser actions. (Closed)

Created:
8 years, 2 months ago by Jeffrey Yasskin
Modified:
8 years, 2 months ago
Reviewers:
kareng
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Merge 157903 - Turn off animations for page actions and browser actions. The icon observation code isn't set up to watch non-script-badges, so page action animations wind up partially complete or cause a white background in script badge mode. A future refactoring to ExtensionAction should make animations work for all types, but this fix is simple to fix the problem on the Chrome 23 and maybe Chrome 22 branches. BUG=141808, 144247, 144248 Review URL: https://chromiumcodereview.appspot.com/10967020 TBR=kareng Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M chrome/common/extensions/extension_action.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_action_unittest.cc View 1 chunk +34 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jeffrey Yasskin
8 years, 2 months ago (2012-10-02 19:58:39 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698