Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1104293007: Fixed flaky test. (Closed)

Created:
5 years, 7 months ago by bcwhite
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed flaky test. It appears to be an issue with the "textarea" not always getting focus before the "commitText()" call is made. A tiny delay to let everything settle seems to fix the issue. BUG=477632 TBR=bcwhite Committed: https://crrev.com/06d12557afa4e1d48c226a6fb852aafb09395fdd Cr-Commit-Position: refs/heads/master@{#327577}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +1 line, -4 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
bcwhite
5 years, 7 months ago (2015-04-29 17:17:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104293007/1
5 years, 7 months ago (2015-04-29 20:56:01 UTC) #4
aurimas (slooooooooow)
https://codereview.chromium.org/1104293007/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/1104293007/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode334 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:334: Thread.sleep(50); Let's use CriteriaHelper.pollForCriteria that checks for the focused ...
5 years, 7 months ago (2015-04-29 20:59:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:45:44 UTC) #6
aurimas (slooooooooow)
TBR yourself? what?
5 years, 7 months ago (2015-04-29 21:46:43 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/06d12557afa4e1d48c226a6fb852aafb09395fdd Cr-Commit-Position: refs/heads/master@{#327577}
5 years, 7 months ago (2015-04-29 21:47:28 UTC) #8
bcwhite
5 years, 7 months ago (2015-04-30 10:46:46 UTC) #9
Message was sent while issue was closed.
The original details of the flaky test were gone and since there were no changes
to Chrome code, I submitted this in order to see if more reports came up.

The odd thing is that I un-checked the commit box but it still continued.

Don't know why I typed my own id, though...  Must have been muscle-memory or
type-without-thinking while remembering a drover merge.  Apologies.

Powered by Google App Engine
This is Rietveld 408576698