Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1104233003: [Effen] fix some dart warnings (mostly unused imports) (Closed)

Created:
5 years, 8 months ago by Hixie
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M sky/framework/animation/animated_value.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/framework/components/animated_component.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/drawer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/framework/components/fixed_height_scrollable.dart View 3 chunks +3 lines, -1 line 0 comments Download
M sky/framework/components/ink_splash.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/framework/components/material.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/framework/components/popup_menu.dart View 2 chunks +1 line, -3 lines 0 comments Download
M sky/framework/components/popup_menu_item.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/framework/components/scaffold.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm I <3 the analyzer.
5 years, 8 months ago (2015-04-27 17:50:31 UTC) #2
Hixie
5 years, 8 months ago (2015-04-27 17:54:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
130784541e5e73522ea0f4001afa92b340ca51a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698