src/runtime/runtime-debug.cc - Issue 1104223002: [es6] implement optional parameters via desugaring (with scoping)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 1104223002: [es6] implement optional parameters via desugaring (with scoping) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Make scoping sort-of work-ish, still no hole-checking Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index d23d0e2322e983aa019cfa3364937df4cd52d324..1790f787ade78eee05fdf30a824f2c5557964e74 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -1339,6 +1339,7 @@ class ScopeIterator {

case CATCH_SCOPE:

DCHECK(context_->IsCatchContext());

return ScopeTypeCatch;

+ case PARAMETER_SCOPE:

case BLOCK_SCOPE:

DCHECK(!scope_info->HasContext() || context_->IsBlockContext());

return ScopeTypeBlock;

« src/globals.h ('K') | « src/preparser.cc ('k') | src/scopes.h » ('j') | no next file with comments »