Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1104183005: Always send the wake-on-wifi setting when the network device list is updated (Closed)

Created:
5 years, 7 months ago by Chirantan Ekbote
Modified:
5 years, 7 months ago
Reviewers:
stevenjb, michaelpg
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always send the wake-on-wifi setting when the network device list is updated If shill happens to restart or re-create the wifi device then the wake on wifi setting will not persist. To deal with this, always send the current wake on wifi setting when the network device list is updated unless the setting hasn't been initialized. BUG=475199 Committed: https://crrev.com/62c854e6aaa291a9e3861b8c6d83bbb76b8392f5 Cr-Commit-Position: refs/heads/master@{#327432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/chromeos/net/wake_on_wifi_manager.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Chirantan Ekbote
ptal
5 years, 7 months ago (2015-04-29 00:31:58 UTC) #2
stevenjb
lgtm
5 years, 7 months ago (2015-04-29 00:44:48 UTC) #3
michaelpg
lgtm
5 years, 7 months ago (2015-04-29 00:50:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104183005/1
5 years, 7 months ago (2015-04-29 00:53:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 04:05:39 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 04:06:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62c854e6aaa291a9e3861b8c6d83bbb76b8392f5
Cr-Commit-Position: refs/heads/master@{#327432}

Powered by Google App Engine
This is Rietveld 408576698