Source/devtools/front_end/elements/MetricsSidebarPane.js - Issue 1104163003: Devtools: [ElementsPanel] Add dom listeners in sidebars

Unified Diff: Source/devtools/front_end/elements/MetricsSidebarPane.js

Issue 1104163003: Devtools: [ElementsPanel] Add dom listeners in sidebars (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@move-force-state

Patch Set: Address comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/elements/ElementsPanel.js ('k') | Source/devtools/front_end/elements/PlatformFontsSidebarPane.js » ('j') | Source/devtools/front_end/sdk/DOMModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/elements/MetricsSidebarPane.js

diff --git a/Source/devtools/front_end/elements/MetricsSidebarPane.js b/Source/devtools/front_end/elements/MetricsSidebarPane.js

index 444c8c94e3066a75183568caba32e059e78ec119..87713ea22afd88e9a2574ae6bd13c9bc34684d3c 100644

--- a/Source/devtools/front_end/elements/MetricsSidebarPane.js

+++ b/Source/devtools/front_end/elements/MetricsSidebarPane.js

@@ -60,6 +60,7 @@ WebInspector.MetricsSidebarPane.prototype = {

this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.StyleSheetChanged, this.update, this);

this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.MediaQueryResultChanged, this.update, this);

this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.PseudoStateForced, this.update, this);

+ this._domModel.removeEventListener(WebInspector.DOMModel.Events.DOMMutated, this.update, this);

this._domModel.removeEventListener(WebInspector.DOMModel.Events.AttrModified, this._attributesUpdated, this);

this._domModel.removeEventListener(WebInspector.DOMModel.Events.AttrRemoved, this._attributesUpdated, this);

this._target.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameResized, this.update, this);

@@ -73,6 +74,7 @@ WebInspector.MetricsSidebarPane.prototype = {

this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.StyleSheetChanged, this.update, this);

this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.MediaQueryResultChanged, this.update, this);

this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.PseudoStateForced, this.update, this);

+ this._domModel.addEventListener(WebInspector.DOMModel.Events.DOMMutated, this.update, this);

this._domModel.addEventListener(WebInspector.DOMModel.Events.AttrModified, this._attributesUpdated, this);

pfeldman 2015/05/05 14:13:07 I assume these should be removed now. Also, you pr

sergeyv 2015/05/06 08:35:54 AttrModified/AttrRemoved usually have separate ha

this._domModel.addEventListener(WebInspector.DOMModel.Events.AttrRemoved, this._attributesUpdated, this);

this._target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameResized, this.update, this);