Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: Source/devtools/front_end/elements/ElementsPanel.js

Issue 1104163003: Devtools: [ElementsPanel] Add dom listeners in sidebars (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@move-force-state
Patch Set: MutationObserver via promises Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/Source/devtools/front_end/elements/ElementsPanel.js b/Source/devtools/front_end/elements/ElementsPanel.js
index 4479787615b25089347081a72fb403eda5abe540..b0a2d1493cf39a15d1186e5ed8831934a2298163 100644
--- a/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/Source/devtools/front_end/elements/ElementsPanel.js
@@ -676,12 +676,11 @@ WebInspector.ElementsPanel.prototype = {
{
/**
* @param {!WebInspector.ElementsTreeOutline} treeOutline
- * @this {WebInspector.ElementsPanel}
*/
function handleUndoRedo(treeOutline)
{
if (WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event) && !event.shiftKey && event.keyIdentifier === "U+005A") { // Z key
- treeOutline.domModel().undo(this._updateSidebars.bind(this));
+ treeOutline.domModel().undo();
event.handled = true;
return;
}
@@ -689,7 +688,7 @@ WebInspector.ElementsPanel.prototype = {
var isRedoKey = WebInspector.isMac() ? event.metaKey && event.shiftKey && event.keyIdentifier === "U+005A" : // Z key
event.ctrlKey && event.keyIdentifier === "U+0059"; // Y key
if (isRedoKey) {
- treeOutline.domModel().redo(this._updateSidebars.bind(this));
+ treeOutline.domModel().redo();
event.handled = true;
}
}
@@ -706,7 +705,7 @@ WebInspector.ElementsPanel.prototype = {
return;
if (!treeOutline.editing()) {
- handleUndoRedo.call(this, treeOutline);
+ handleUndoRedo.call(null, treeOutline);
if (event.handled)
return;
}
« no previous file with comments | « no previous file | Source/devtools/front_end/elements/MetricsSidebarPane.js » ('j') | Source/devtools/front_end/sdk/DOMModel.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698