Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: Source/devtools/front_end/elements/ElementsSidebarPane.js

Issue 1104163003: Devtools: [ElementsPanel] Add dom listeners in sidebars (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@move-force-state
Patch Set: Address comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/ElementsSidebarPane.js
diff --git a/Source/devtools/front_end/elements/ElementsSidebarPane.js b/Source/devtools/front_end/elements/ElementsSidebarPane.js
index 87516660d76a0e763c8ac2099338b54f9698aec8..b19bc0da96ade35e4d8843c9dbab1d9881bf0c00 100644
--- a/Source/devtools/front_end/elements/ElementsSidebarPane.js
+++ b/Source/devtools/front_end/elements/ElementsSidebarPane.js
@@ -75,9 +75,7 @@ WebInspector.ElementsSidebarPane.prototype = {
this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.MediaQueryResultChanged, this.onCSSModelChanged, this);
this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.PseudoStateForced, this.onCSSModelChanged, this);
this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.ModelWasEnabled, this.onCSSModelChanged, this);
- this._domModel.removeEventListener(WebInspector.DOMModel.Events.AttrModified, this._onAttributeChanged, this);
- this._domModel.removeEventListener(WebInspector.DOMModel.Events.AttrRemoved, this._onAttributeChanged, this);
- this._domModel.removeEventListener(WebInspector.DOMModel.Events.CharacterDataModified, this._onCharDataChanged, this);
+ this._domModel.removeEventListener(WebInspector.DOMModel.Events.DOMMutated, this.onDOMModelChanged, this);
this._target.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameResized, this._onFrameResized, this);
}
this._target = target;
@@ -90,9 +88,7 @@ WebInspector.ElementsSidebarPane.prototype = {
this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.PseudoStateForced, this.onCSSModelChanged, this);
this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.ModelWasEnabled, this.onCSSModelChanged, this);
this._domModel = WebInspector.DOMModel.fromTarget(target);
- this._domModel.addEventListener(WebInspector.DOMModel.Events.AttrModified, this._onAttributeChanged, this);
- this._domModel.addEventListener(WebInspector.DOMModel.Events.AttrRemoved, this._onAttributeChanged, this);
- this._domModel.addEventListener(WebInspector.DOMModel.Events.CharacterDataModified, this._onCharDataChanged, this);
+ this._domModel.addEventListener(WebInspector.DOMModel.Events.DOMMutated, this.onDOMModelChanged, this);
this._target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameResized, this._onFrameResized, this);
}
},
@@ -100,22 +96,6 @@ WebInspector.ElementsSidebarPane.prototype = {
/**
* @param {!WebInspector.Event} event
*/
- _onAttributeChanged: function(event)
- {
- this.onDOMNodeChanged(/** @type {!WebInspector.DOMNode} */(event.data.node));
- },
-
- /**
- * @param {!WebInspector.Event} event
- */
- _onCharDataChanged: function(event)
- {
- this.onDOMNodeChanged(/** @type {!WebInspector.DOMNode} */(event.data));
- },
-
- /**
- * @param {!WebInspector.Event} event
- */
_onFrameResized: function(event)
{
/**
@@ -133,10 +113,7 @@ WebInspector.ElementsSidebarPane.prototype = {
this._frameResizedTimer = setTimeout(refreshContents.bind(this), 100);
},
- /**
- * @param {!WebInspector.DOMNode} changedNode
- */
- onDOMNodeChanged: function(changedNode) { },
+ onDOMModelChanged: function() { },
onCSSModelChanged: function() { },
« no previous file with comments | « Source/devtools/front_end/elements/ElementsPanel.js ('k') | Source/devtools/front_end/elements/MetricsSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698