Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 1104163003: Devtools: [ElementsPanel] Add dom listeners in sidebars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 1104163003: Devtools: [ElementsPanel] Add dom listeners in sidebars (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@move-force-state

Patch Set: Address offline comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/elements/MetricsSidebarPane.js ('K') | « Source/devtools/front_end/elements/PlatformFontsSidebarPane.js ('k') | Source/devtools/front_end/sdk/DOMModel.js » ('j') | Source/devtools/front_end/sdk/DOMModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/Source/devtools/front_end/elements/StylesSidebarPane.js b/Source/devtools/front_end/elements/StylesSidebarPane.js

index 62b389cfa6d8e24c75330de624b5ad1f1597cee3..a44ac8d4389206f01abd8530919c67b01df3e1d0 100644

--- a/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -520,18 +520,14 @@ WebInspector.StylesSidebarPane.prototype = {

/**

* @override

- * @param {!WebInspector.DOMNode} changedNode

- onDOMNodeChanged: function(changedNode)

+ onDOMModelChanged: function()

{

// Any attribute removal or modification can affect the styles of "related" nodes.

// Do not touch the styles if they are being edited.

if (this._isEditingStyle || this._userOperation)

return;

- if (!this._canAffectCurrentStyles(changedNode))

- return;

this._resetCache();

this.update();