Devtools: [ElementsPanel] Add dom listeners in sidebars

Source/devtools/front_end/elements/MetricsSidebarPane.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 42 matching lines @@
     {
         if (this._target === target)
             return;
 
         if (this._target) {
             this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.StyleSheetAdded, this.update, this);
             this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.StyleSheetRemoved, this.update, this);
             this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.StyleSheetChanged, this.update, this);
             this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.MediaQueryResultChanged, this.update, this);
             this._cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.PseudoStateForced, this.update, this);
+            this._domModel.removeEventListener(WebInspector.DOMModel.Events.NodeInserted, this.update, this);

[pfeldman, 2015/04/28 05:53:20]

Can we extract a helper object that would listen to these and would fire a
single event in return?
Alternatively, we could introduce a new artificial event that would fire upon
_any_ of these DOM changes.

[sergeyv, 2015/04/28 08:53:25]

Done.

+            this._domModel.removeEventListener(WebInspector.DOMModel.Events.NodeRemoved, this.update, this);
+            this._domModel.removeEventListener(WebInspector.DOMModel.Events.DistributedNodesChanged, this.update, this);
             this._domModel.removeEventListener(WebInspector.DOMModel.Events.AttrModified, this._attributesUpdated, this);
             this._domModel.removeEventListener(WebInspector.DOMModel.Events.AttrRemoved, this._attributesUpdated, this);
             this._target.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameResized, this.update, this);
         }
         this._target = target;
         if (target) {
             this._domModel = WebInspector.DOMModel.fromTarget(target);
             this._cssModel = WebInspector.CSSStyleModel.fromTarget(target);
             this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.StyleSheetAdded, this.update, this);
             this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.StyleSheetRemoved, this.update, this);
             this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.StyleSheetChanged, this.update, this);
             this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.MediaQueryResultChanged, this.update, this);
             this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.PseudoStateForced, this.update, this);
+            this._domModel.addEventListener(WebInspector.DOMModel.Events.NodeInserted, this.update, this);
+            this._domModel.addEventListener(WebInspector.DOMModel.Events.NodeRemoved, this.update, this);
+            this._domModel.addEventListener(WebInspector.DOMModel.Events.DistributedNodesChanged, this.update, this);
             this._domModel.addEventListener(WebInspector.DOMModel.Events.AttrModified, this._attributesUpdated, this);
             this._domModel.addEventListener(WebInspector.DOMModel.Events.AttrRemoved, this._attributesUpdated, this);
             this._target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameResized, this.update, this);
         }
     },
 
     /**
      * @override
      * @param {!WebInspector.Throttler.FinishCallback} finishedCallback
      * @protected
@@ skipping 397 matching lines @@
     },
 
     editingCommitted: function(element, userInput, previousContent, context)
     {
         this.editingEnded(element, context);
         this._applyUserInput(element, userInput, previousContent, context, true);
     },
 
     __proto__: WebInspector.ElementsSidebarPane.prototype
 }