Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1104163003: Devtools: [ElementsPanel] Add dom listeners in sidebars (Closed)

Created:
5 years, 7 months ago by sergeyv
Modified:
5 years, 6 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@move-force-state
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: [ElementsPanel] Add dom listeners in sidebars BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195937

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Patch Set 3 : MutationObserver via promises #

Total comments: 6

Patch Set 4 : Address comments #

Total comments: 4

Patch Set 5 : Rename method #

Total comments: 2

Patch Set 6 : Rebase #

Patch Set 7 : Address offline comments #

Total comments: 7

Patch Set 8 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -54 lines) Patch
M Source/devtools/front_end/elements/ComputedStyleSidebarPane.js View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsSidebarPane.js View 1 2 3 4 5 6 7 4 chunks +3 lines, -26 lines 0 comments Download
M Source/devtools/front_end/elements/MetricsSidebarPane.js View 1 2 3 4 5 6 1 chunk +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/elements/PlatformFontsSidebarPane.js View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 3 4 5 6 7 1 chunk +1 line, -14 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 1 2 3 4 5 6 7 14 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 20 (4 generated)
sergeyv
5 years, 7 months ago (2015-04-27 17:01:50 UTC) #2
pfeldman
https://codereview.chromium.org/1104163003/diff/1/Source/devtools/front_end/elements/MetricsSidebarPane.js File Source/devtools/front_end/elements/MetricsSidebarPane.js (right): https://codereview.chromium.org/1104163003/diff/1/Source/devtools/front_end/elements/MetricsSidebarPane.js#newcode63 Source/devtools/front_end/elements/MetricsSidebarPane.js:63: this._domModel.removeEventListener(WebInspector.DOMModel.Events.NodeInserted, this.update, this); Can we extract a helper object ...
5 years, 7 months ago (2015-04-28 05:53:21 UTC) #3
sergeyv
https://codereview.chromium.org/1104163003/diff/1/Source/devtools/front_end/elements/MetricsSidebarPane.js File Source/devtools/front_end/elements/MetricsSidebarPane.js (right): https://codereview.chromium.org/1104163003/diff/1/Source/devtools/front_end/elements/MetricsSidebarPane.js#newcode63 Source/devtools/front_end/elements/MetricsSidebarPane.js:63: this._domModel.removeEventListener(WebInspector.DOMModel.Events.NodeInserted, this.update, this); On 2015/04/28 05:53:20, pfeldman wrote: > ...
5 years, 7 months ago (2015-04-28 08:53:26 UTC) #4
pfeldman
https://codereview.chromium.org/1104163003/diff/40001/Source/devtools/front_end/sdk/DOMModel.js File Source/devtools/front_end/sdk/DOMModel.js (right): https://codereview.chromium.org/1104163003/diff/40001/Source/devtools/front_end/sdk/DOMModel.js#newcode1132 Source/devtools/front_end/sdk/DOMModel.js:1132: this._lastMutationId = (this._lastMutationId || 0) + 1; fast return ...
5 years, 7 months ago (2015-04-29 13:53:16 UTC) #5
sergeyv
https://codereview.chromium.org/1104163003/diff/40001/Source/devtools/front_end/sdk/DOMModel.js File Source/devtools/front_end/sdk/DOMModel.js (right): https://codereview.chromium.org/1104163003/diff/40001/Source/devtools/front_end/sdk/DOMModel.js#newcode1132 Source/devtools/front_end/sdk/DOMModel.js:1132: this._lastMutationId = (this._lastMutationId || 0) + 1; On 2015/04/29 ...
5 years, 7 months ago (2015-04-30 12:34:13 UTC) #7
sergeyv
ptal
5 years, 7 months ago (2015-05-05 09:23:40 UTC) #8
pfeldman
https://codereview.chromium.org/1104163003/diff/80001/Source/devtools/front_end/elements/MetricsSidebarPane.js File Source/devtools/front_end/elements/MetricsSidebarPane.js (right): https://codereview.chromium.org/1104163003/diff/80001/Source/devtools/front_end/elements/MetricsSidebarPane.js#newcode78 Source/devtools/front_end/elements/MetricsSidebarPane.js:78: this._domModel.addEventListener(WebInspector.DOMModel.Events.AttrModified, this._attributesUpdated, this); I assume these should be removed ...
5 years, 7 months ago (2015-05-05 14:13:07 UTC) #9
sergeyv
https://codereview.chromium.org/1104163003/diff/80001/Source/devtools/front_end/elements/MetricsSidebarPane.js File Source/devtools/front_end/elements/MetricsSidebarPane.js (right): https://codereview.chromium.org/1104163003/diff/80001/Source/devtools/front_end/elements/MetricsSidebarPane.js#newcode78 Source/devtools/front_end/elements/MetricsSidebarPane.js:78: this._domModel.addEventListener(WebInspector.DOMModel.Events.AttrModified, this._attributesUpdated, this); On 2015/05/05 14:13:07, pfeldman_ooo_may11 wrote: > ...
5 years, 7 months ago (2015-05-06 08:35:54 UTC) #10
sergeyv
please take a look
5 years, 7 months ago (2015-05-07 10:07:52 UTC) #11
pfeldman
https://codereview.chromium.org/1104163003/diff/100001/Source/devtools/front_end/elements/PlatformFontsSidebarPane.js File Source/devtools/front_end/elements/PlatformFontsSidebarPane.js (right): https://codereview.chromium.org/1104163003/diff/100001/Source/devtools/front_end/elements/PlatformFontsSidebarPane.js#newcode86 Source/devtools/front_end/elements/PlatformFontsSidebarPane.js:86: this._domModel.addEventListener(WebInspector.DOMModel.Events.AttrModified, this.update, this); These are all updates, why are ...
5 years, 7 months ago (2015-05-07 12:35:06 UTC) #12
pfeldman
lgtm
5 years, 7 months ago (2015-05-16 00:08:23 UTC) #13
lushnikov
https://codereview.chromium.org/1104163003/diff/100001/Source/devtools/front_end/sdk/DOMModel.js File Source/devtools/front_end/sdk/DOMModel.js (right): https://codereview.chromium.org/1104163003/diff/100001/Source/devtools/front_end/sdk/DOMModel.js#newcode1079 Source/devtools/front_end/sdk/DOMModel.js:1079: DOMMutated: "DOMMutated", can we call this DOMMutatedThrottled to differentiate ...
5 years, 6 months ago (2015-05-26 16:10:45 UTC) #14
lushnikov
lgtm https://codereview.chromium.org/1104163003/diff/140001/Source/devtools/front_end/elements/MetricsSidebarPane.js File Source/devtools/front_end/elements/MetricsSidebarPane.js (left): https://codereview.chromium.org/1104163003/diff/140001/Source/devtools/front_end/elements/MetricsSidebarPane.js#oldcode93 Source/devtools/front_end/elements/MetricsSidebarPane.js:93: if (this.node() !== changedNode) yay! https://codereview.chromium.org/1104163003/diff/140001/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js ...
5 years, 6 months ago (2015-05-26 18:24:30 UTC) #15
sergeyv
https://codereview.chromium.org/1104163003/diff/140001/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/1104163003/diff/140001/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode538 Source/devtools/front_end/elements/StylesSidebarPane.js:538: _canAffectCurrentStyles: function(node) On 2015/05/26 18:24:30, lushnikov wrote: > you ...
5 years, 6 months ago (2015-05-26 21:09:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104163003/160001
5 years, 6 months ago (2015-05-26 21:10:00 UTC) #19
commit-bot: I haz the power
5 years, 6 months ago (2015-05-26 23:26:39 UTC) #20
Message was sent while issue was closed. 
Committed patchset #8 (id:160001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195937

Powered by Google App Engine
This is Rietveld 408576698