Issue 1104163002: Revert of deprecate non-phantom weak callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1104163002: Revert of deprecate non-phantom weak callbacks (Closed)

Created:
5 years, 8 months ago by Michael Achenbach

Modified:
5 years, 8 months ago

Reviewers:
dcarney, jochen (gone - plz use gerrit)

CC:
Paweł Hajdan Jr., v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of deprecate non-phantom weak callbacks (patchset #1 id:1 of https://codereview.chromium.org/1103173002/) Reason for revert: [Sheriff] Fails compilation on chromium android: http://build.chromium.org/p/client.v8/builders/Android%20Builder/builds/4131 Is the chromium version our builder used maybe too old (it uses lkcr)? In that case please reland as soon as it's up-to-date. Original issue's description: > deprecate non-phantom weak callbacks > > BUG= > > Committed: https://crrev.com/39c31da2142ab0fca9dae279b9e59cd4951a1982 > Cr-Commit-Position: refs/heads/master@{#28077} TBR=jochen@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c5797f859aa775633cd156432a1ed677974a52a6 Cr-Commit-Position: refs/heads/master@{#28079}

Created: 5 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	include/v8.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of deprecate non-phantom weak callbacks

5 years, 8 months ago (2015-04-27 13:30:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104163002/1

5 years, 8 months ago (2015-04-27 13:30:33 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-27 13:31:02 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c5797f859aa775633cd156432a1ed677974a52a6
Cr-Commit-Position: refs/heads/master@{#28079}