Expose ReconcilorState. Rename MergeSession in Signin Tracker.

Expose AccountReconcilor State mostly for iOS.
Rename MergeSession in SigninTracker.

Further cleanup as part of the MergeSession/GCMS rework. https://docs.google.com/document/d/1FfmSS7M87L_2tkVuHO3NuruborFm6qHXe2VdktZg-HQ

BUG=466799, 471210
Committed: https://crrev.com/ee9049e5b2e4ddd2c896ba9c9d991b2d59a00977
Cr-Commit-Position: refs/heads/master@{#327268}

[Mike Lerman, 2015-04-27 13:29:08]

mlerman@chromium.org changed reviewers:
+ bzanotti@chromium.org

[Mike Lerman, 2015-04-27 13:29:09]

Hi Benoit,

This is the CL that will add visibility into the state of the Reconcilor. Can
you take a look at account_reconcilor.h - does this work for you? Thanks!

Mike

[bzanotti, 2015-04-27 13:48:16]

Hey Mike

On 2015/04/27 13:29:09, Mike Lerman wrote:
> This is the CL that will add visibility into the state of the Reconcilor. Can
> you take a look at account_reconcilor.h - does this work for you? Thanks!

This API looks good to me and exposes all the informations we will need.
Again, thanks for doing this.

[Mike Lerman, 2015-04-27 19:12:20]

mlerman@chromium.org changed reviewers:
+ rogerta@chromium.org

[Mike Lerman, 2015-04-27 19:12:20]

Hi Roger,

Next CL in the train. Thanks for taking a look!

Mike

[Roger Tawa OOO till Jul 10th, 2015-04-27 20:08:49]

lgtm, a couple of nits below to help debugging.

https://codereview.chromium.org/1104153002/diff/20001/components/signin/core/...
File components/signin/core/browser/account_reconcilor.cc (right):

https://codereview.chromium.org/1104153002/diff/20001/components/signin/core/...
components/signin/core/browser/account_reconcilor.cc:286: if (error.state() ==
GoogleServiceAuthError::NONE) {
Nit: can you add a VLOG above the if?

https://codereview.chromium.org/1104153002/diff/20001/components/signin/core/...
components/signin/core/browser/account_reconcilor.cc:451: // Always listens to
GaiaCookieManagerService. Only proceed if reconciling.
Nit: can you add a VLOG here?

[Mike Lerman, 2015-04-27 20:16:49]

I'd vlove to!

https://codereview.chromium.org/1104153002/diff/20001/components/signin/core/...
File components/signin/core/browser/account_reconcilor.cc (right):

https://codereview.chromium.org/1104153002/diff/20001/components/signin/core/...
components/signin/core/browser/account_reconcilor.cc:286: if (error.state() ==
GoogleServiceAuthError::NONE) {
On 2015/04/27 20:08:49, Roger Tawa wrote:
> Nit: can you add a VLOG above the if?

Done.

https://codereview.chromium.org/1104153002/diff/20001/components/signin/core/...
components/signin/core/browser/account_reconcilor.cc:451: // Always listens to
GaiaCookieManagerService. Only proceed if reconciling.
On 2015/04/27 20:08:49, Roger Tawa wrote:
> Nit: can you add a VLOG here?

Done.

[Mike Lerman, 2015-04-28 11:04:15]

The CQ bit was checked by mlerman@chromium.org

[Mike Lerman, 2015-04-28 11:04:16]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/1104153002/#ps40001
(title: "VLOGging the reconcilor")

[commit-bot: I haz the power, 2015-04-28 11:04:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104153002/40001

[commit-bot: I haz the power, 2015-04-28 12:00:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-28 12:01:18]

Patchset 3 (id:??) landed as
https://crrev.com/ee9049e5b2e4ddd2c896ba9c9d991b2d59a00977
Cr-Commit-Position: refs/heads/master@{#327268}