Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 1104123002: Extending v8::GetHeapStatistics to return total available size. (Closed)

Created:
5 years, 8 months ago by ssid
Modified:
5 years, 8 months ago
CC:
picksi1, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Extending v8::GetHeapStatistics to return total available size. For dumping memory statistics about v8 heap, we need the total available size of the heap. This CL adds extra field in HeapStatistics to return the available size. BUG=476013 LOG=Y Committed: https://crrev.com/0a1352a716e9af5d861dcede0d7c6580f018a10b Cr-Commit-Position: refs/heads/master@{#28100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/v8.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ssid
3 line patch, PTAL.
5 years, 8 months ago (2015-04-27 13:07:59 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-27 19:50:23 UTC) #3
rmcilroy
On 2015/04/27 19:50:23, jochen wrote: > lgtm lgtm.
5 years, 8 months ago (2015-04-28 09:02:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104123002/1
5 years, 8 months ago (2015-04-28 10:21:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2307)
5 years, 8 months ago (2015-04-28 10:24:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104123002/1
5 years, 8 months ago (2015-04-28 10:56:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 10:57:45 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 10:57:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a1352a716e9af5d861dcede0d7c6580f018a10b
Cr-Commit-Position: refs/heads/master@{#28100}

Powered by Google App Engine
This is Rietveld 408576698