Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1104073003: X87: Don't MISS if you read the hole from certain FastHoley arrays. (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
mvstanton, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Don't MISS if you read the hole from certain FastHoley arrays. port caeb9004f0bfc2a916fc63e9d27100a3110016d4 (r28056) original commit message: If the array's map is the initial FastHoley array map, and the array prototype chain is undisturbed and empty of elements, then keyed loads can convert the load of a hole to undefined. BUG= Committed: https://crrev.com/77a2c15fb4016dfebf9cb5a1ef7e3c5c0b32f8ac Cr-Commit-Position: refs/heads/master@{#28128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +15 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-27 16:28:27 UTC) #2
chunyang.dai
PTAL because the owner of X87 (Weiliang) asked for annual leave. Thanks.
5 years, 7 months ago (2015-04-28 16:32:57 UTC) #4
mvstanton
lgtm
5 years, 7 months ago (2015-04-29 06:27:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104073003/1
5 years, 7 months ago (2015-04-29 10:10:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 10:34:24 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 10:34:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77a2c15fb4016dfebf9cb5a1ef7e3c5c0b32f8ac
Cr-Commit-Position: refs/heads/master@{#28128}

Powered by Google App Engine
This is Rietveld 408576698