Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1104073002: Revert of [test] Make msan work for v8 stand-alone. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] Make msan work for v8 stand-alone. (patchset #6 id:100001 of https://codereview.chromium.org/802583003/) Reason for revert: Compile failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2047 Original issue's description: > [test] Make msan work for v8 stand-alone. > > The msan configuration can be used in combination with > v8_use_snapshot=false. > > BUG=chromium:425187 > LOG=n > > Committed: https://crrev.com/a65ef0d53fc28b0908f228938c6d84effa83c596 > Cr-Commit-Position: refs/heads/master@{#28064} TBR=jochen@chromium.org,earthdok@chromium.org,svenpanne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:425187 Committed: https://crrev.com/f69a48696ec3ec0ea1169a41b4c84fb36b059968 Cr-Commit-Position: refs/heads/master@{#28068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M build/standalone.gypi View 2 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [test] Make msan work for v8 stand-alone.
5 years, 8 months ago (2015-04-27 11:14:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104073002/1
5 years, 8 months ago (2015-04-27 11:14:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 11:14:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f69a48696ec3ec0ea1169a41b4c84fb36b059968 Cr-Commit-Position: refs/heads/master@{#28068}
5 years, 8 months ago (2015-04-27 11:14:50 UTC) #4
Michael Achenbach
5 years, 8 months ago (2015-04-27 13:19:27 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1102323002/ by machenbach@chromium.org.

The reason for reverting is: Reland after switching bot to ninja..

Powered by Google App Engine
This is Rietveld 408576698