Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tests/corelib/growable_list_test.dart

Issue 1104063002: Make EfficientLength public, as EfficientLengthIterable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/internal/iterable.dart ('K') | « sdk/lib/internal/iterable.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/growable_list_test.dart
diff --git a/tests/corelib/growable_list_test.dart b/tests/corelib/growable_list_test.dart
index 98b4e1ff725350336f499d615986202b4d4200b0..0e26138a9f8213b5e63f7dd87b0e960896efbec6 100644
--- a/tests/corelib/growable_list_test.dart
+++ b/tests/corelib/growable_list_test.dart
@@ -5,11 +5,11 @@
// Sanity check on the growing behavior of a growable list.
import "package:expect/expect.dart";
-import "dart:collection" show IterableBase;
+import "dart:collection" show EfficientLengthIterable;
// Iterable generating numbers in range [0..count).
// May perform callback at some point underways.
-class TestIterableBase extends IterableBase<int> {
+class TestIterableBase extends Iterable<int> {
final int length;
final int count;
// call [callback] if generating callbackIndex.
@@ -26,9 +26,8 @@ class TestIterable extends TestIterableBase {
int get length => throw "SHOULD NOT BE CALLED";
}
-// Implement Set for private EfficientLength interface.
class EfficientTestIterable extends TestIterableBase
- implements Set<int> {
+ implements EfficientLengthIterable<int> {
EfficientTestIterable(length, count, [callbackIndex = -1, callback])
: super(length, count, callbackIndex, callback);
// Avoid warnings because we don't actually implement Set.
@@ -57,7 +56,7 @@ class CallbackIterator implements Iterator<int> {
void main() {
- // Without EfficientLength interface
+ // Without EfficientLengthIterable interface
{
// Change length of list after 20 additions.
var l = [];
@@ -80,7 +79,7 @@ void main() {
}, (e) => e is ConcurrentModificationError);
}
- // With EfficientLength interface (uses length).
+ // With EfficientLengthIterable interface (uses length).
{
// Change length of list after 20 additions.
var l = [];
« sdk/lib/internal/iterable.dart ('K') | « sdk/lib/internal/iterable.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698