Handle NFC permission being unavailable.

Handle NFC permission being unavailable.

With a rooted device, some apps can remove permissions. Prevents chrome
from crashing if NFC is revoked.

BUG=481979
Committed: https://crrev.com/2af423f68fbcd51366b90ba953ead51b16f0b85b
Cr-Commit-Position: refs/heads/master@{#327571}

[Yaron, 2015-04-29 20:12:38]

yfriedman@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2015-04-29 20:36:23]

lgtm

On Wed, Apr 29, 2015, 13:12  <yfriedman@chromium.org> wrote:

> Reviewers: nyquist,
>
> Description:
> Handle NFC permission being unavailable.
>
> With a rooted device, some apps can remove permissions. Prevents chrome
> from crashing if NFC is revoked.
>
> BUG=481979
>
> Please review this at https://codereview.chromium.org/1104053003/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -1 lines):
>    M
> chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamController.java
>
>
> Index:
> chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamController.java
> diff --git
>
> a/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamController.java
>
> b/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamController.java
> index
>
>
105daa63a9b7e3a2e53e9b61bd271b6da7059251..8e9f5b1c016d552a1e364a0fcb4dabb83e90b58d
> 100644
> ---
>
> a/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamController.java
> +++
>
> b/chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamController.java
> @@ -27,7 +27,7 @@ public final class BeamController {
>               final BeamCallback beamCallback = new BeamCallback(activity,
> provider);
>               nfcAdapter.setNdefPushMessageCallback(beamCallback,
> activity);
>               nfcAdapter.setOnNdefPushCompleteCallback(beamCallback,
> activity);
> -        } catch (IllegalStateException e) {
> +        } catch (IllegalStateException | SecurityException e) {
>               Log.w("BeamController", "NFC registration failure. Can't
> retry, giving up.");
>           }
>       }
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nyquist, 2015-04-29 20:40:21]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2015-04-29 20:40:21]

lgtm

[Yaron, 2015-04-29 20:40:28]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2015-04-29 20:42:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104053003/1

[commit-bot: I haz the power, 2015-04-29 21:41:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-29 21:42:34]

Patchset 1 (id:??) landed as
https://crrev.com/2af423f68fbcd51366b90ba953ead51b16f0b85b
Cr-Commit-Position: refs/heads/master@{#327571}