Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 1104013002: Revert of ozone: Add ability to set clinet capabilities which we will need for atomic (Closed)

Created:
5 years, 7 months ago by Nikita (slow)
Modified:
5 years, 7 months ago
Reviewers:
dnicoara, achaulk
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ozone: Add ability to set clinet capabilities which we will need for atomic (patchset #2 id:20001 of https://codereview.chromium.org/1100803004/) Reason for revert: Speculative revert - Linux ChromiumOS Ozone Tests is broken. http://goo.gl/vykWsG Original issue's description: > ozone: Add ability to set client capabilities which we will need for atomic > > Committed: https://crrev.com/e5983b7fde9d576bd514490106564e2238eb0713 > Cr-Commit-Position: refs/heads/master@{#326860} TBR=dnicoara@chromium.org,achaulk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4e0c10924dfe3ffd0a1ffc2a99825948d6e35dfb Cr-Commit-Position: refs/heads/master@{#327018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -29 lines) Patch
M ui/ozone/platform/drm/gpu/drm_device.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc View 2 chunks +7 lines, -17 lines 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Nikita (slow)
Created Revert of ozone: Add ability to set clinet capabilities which we will need for ...
5 years, 7 months ago (2015-04-27 08:38:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104013002/1
5 years, 7 months ago (2015-04-27 08:39:07 UTC) #2
commit-bot: I haz the power
Failed to apply patch for ui/ozone/platform/drm/gpu/drm_device.h: While running git apply --index -3 -p1; error: patch ...
5 years, 7 months ago (2015-04-27 08:39:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104013002/1
5 years, 7 months ago (2015-04-27 09:06:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 09:06:33 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4e0c10924dfe3ffd0a1ffc2a99825948d6e35dfb Cr-Commit-Position: refs/heads/master@{#327018}
5 years, 7 months ago (2015-04-27 09:07:26 UTC) #9
Nikita (slow)
5 years, 7 months ago (2015-04-27 09:49:08 UTC) #10
Message was sent while issue was closed.
Most unit_tests failed with

/mnt/data/b/build/slave/Linux_ChromiumOS_Ozone_Tests__1_/build/src/out/Release/app_shell_unittests:
symbol lookup error:
/mnt/data/b/build/slave/Linux_ChromiumOS_Ozone_Tests__1_/build/src/out/Release/app_shell_unittests:
undefined symbol: drmSetClientCap

Powered by Google App Engine
This is Rietveld 408576698