Issue 11040053: retry 160232

Issue 11040053: retry 160232 (Closed)

Created:
8 years, 2 months ago by Evan Stade

Modified:
8 years, 2 months ago

Reviewers:
Albert Bodenhamer, Greg Billock

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org, rouslan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

retry 160232 gtk: improve web intent picker inline intent display BUG=153998 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162193

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : sync changes #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -21 lines)			Patch
M	chrome/browser/ui/gtk/constrained_window_gtk.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/constrained_window_gtk.cc	View	1 2	3 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/gtk/web_intent_picker_gtk.h	View	1 2	3 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/web_intent_picker_gtk.cc	View	1 2	7 chunks	+23 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

I am disappointed that the commit queue failed to catch this. The problem is that ...

8 years, 2 months ago (2012-10-05 09:04:51 UTC) #1

Greg Billock

8 years, 2 months ago (2012-10-05 15:51:29 UTC) #2

On 2012/10/05 09:04:51, Evan Stade wrote:
> I am disappointed that the commit queue failed to catch this. The problem is
> that the CQ only runs in release mode it seems, and GTK_IS_WIDGET only causes
> problems in debug. See this test run from the CQ pass:
> 
> [ RUN      ] PrintPreviewWebUITest.TestPrinterList
> [15935:15935:1004/124625:2193305326:ERROR:browser_main_loop.cc(171)] Gtk:
> gtk_widget_modify_base: assertion `GTK_IS_WIDGET (widget)' failed
> [15935:15935:1004/124625:2193594533:ERROR:browser_main_loop.cc(171)] Gtk:
> gtk_widget_modify_fg: assertion `GTK_IS_WIDGET (widget)' failed
> [15935:15935:1004/124625:2193594610:ERROR:browser_main_loop.cc(171)] Gtk:
> gtk_widget_modify_bg: assertion `GTK_IS_WIDGET (widget)' failed
> [15935:15935:1004/124626:2194964794:INFO:CONSOLE(1632)] "Running TestCase
> PrintPreviewWebUITest.TestPrinterList", source:  (1632)
> [       OK ]
> 
>
http://codereview.chromium.org/11040053/diff/5003/chrome/browser/ui/gtk/const...
> File chrome/browser/ui/gtk/constrained_window_gtk.cc (right):
> 
>
http://codereview.chromium.org/11040053/diff/5003/chrome/browser/ui/gtk/const...
> chrome/browser/ui/gtk/constrained_window_gtk.cc:69: BackgroundColorChanged();
> the fix was moving this below L67.

That is a pain.

lgtm

Expand Messages | Collapse Messages