Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 11040003: Compile code within Visual Studio using gcc rather than g++ (Closed)

Created:
8 years, 2 months ago by Sam Clegg
Modified:
8 years, 2 months ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Compile code within Visual Studio using gcc rather than g++ This way the file extension will determine the file type rather than assuming C++ even for .c files. BUG=152085 Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1424

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
8 years, 2 months ago (2012-10-01 18:19:18 UTC) #1
binji
lgtm
8 years, 2 months ago (2012-10-01 18:20:22 UTC) #2
noelallen1
http://codereview.chromium.org/11040003/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets File visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets (right): http://codereview.chromium.org/11040003/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets#newcode29 visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets:29: NaCLCompilerPath ="$(VSNaClSDKRoot)\toolchain\win_x86_$(ToolchainName)\bin\$(TargetArchitecture)-nacl-gcc.exe" How are you compiling files that are ...
8 years, 2 months ago (2012-10-01 18:54:17 UTC) #3
Sam Clegg
http://codereview.chromium.org/11040003/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets File visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets (right): http://codereview.chromium.org/11040003/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets#newcode29 visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets:29: NaCLCompilerPath ="$(VSNaClSDKRoot)\toolchain\win_x86_$(ToolchainName)\bin\$(TargetArchitecture)-nacl-gcc.exe" On 2012/10/01 18:54:17, noelallen1 wrote: > How ...
8 years, 2 months ago (2012-10-01 19:37:32 UTC) #4
Sam Clegg
8 years, 2 months ago (2012-10-02 18:11:19 UTC) #5
On 2012/10/01 19:37:32, Sam Clegg wrote:
>
http://codereview.chromium.org/11040003/diff/1/visual_studio/NativeClientVSAd...
> File
>
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets
> (right):
> 
>
http://codereview.chromium.org/11040003/diff/1/visual_studio/NativeClientVSAd...
>
visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets:29:
> NaCLCompilerPath                  
>
="$(VSNaClSDKRoot)\toolchain\win_x86_$(ToolchainName)\bin\$(TargetArchitecture)-nacl-gcc.exe"
> On 2012/10/01 18:54:17, noelallen1 wrote:
> > How are you compiling files that are C++?
> 
> Apparently if you call "gcc" it will detect the file
> type based on the extension.  If you call g++ it will
> always be c++ even for .c files.  I just discovered this
> today myself.

Are you OK with this noel.  I could write more code to run g++ or
gcc conditionally but this current method seem to work fine.

Powered by Google App Engine
This is Rietveld 408576698