Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1103943002: Fix ewt_manifest.gyp to support both target and host toolchains (Closed)

Created:
5 years, 8 months ago by sbc
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, Sam Clegg
CC:
Georges Khalil, chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ewt_manifest.gyp to support both target and host toolchains Since base builds for both host and target so much ewt_manifest. Without this gyp will fail when GYP_CROSSCOMPILE=1 and target_arch=arm: gyp: Dependency 'S:\src\base\trace_event\etw_manifest\etw_manifest.gyp:etw_manifest#host' not found while trying to load target S:\src\base\base.gyp:base#host CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk BUG=none Committed: https://crrev.com/7c64f265edca18adefe01d0a4e676a3f7b834bd1 Cr-Commit-Position: refs/heads/master@{#327379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/trace_event/etw_manifest/etw_manifest.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103943002/1
5 years, 8 months ago (2015-04-25 00:55:31 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_nacl_sdk on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_nacl_sdk/builds/439)
5 years, 8 months ago (2015-04-25 04:13:25 UTC) #5
Georges Khalil
+thestig as reviewer.
5 years, 7 months ago (2015-04-28 17:30:23 UTC) #7
Lei Zhang
lgtm
5 years, 7 months ago (2015-04-28 18:11:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103943002/1
5 years, 7 months ago (2015-04-28 18:35:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_nacl_sdk on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_nacl_sdk/builds/443)
5 years, 7 months ago (2015-04-28 20:55:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103943002/1
5 years, 7 months ago (2015-04-28 21:11:06 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 22:38:58 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 22:39:56 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c64f265edca18adefe01d0a4e676a3f7b834bd1
Cr-Commit-Position: refs/heads/master@{#327379}

Powered by Google App Engine
This is Rietveld 408576698