Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 110393002: Move PlatformSpeech stuff to platform/ (Closed)

Created:
7 years ago by pilgrim_google
Modified:
7 years ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, tommyw+watchlist_chromium.org, dglazkov+blink, abarth-chromium, darin (slow to review)
Visibility:
Public.

Description

Move PlatformSpeech stuff to platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163562

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove unnecessary export macros #

Patch Set 3 : WTF_MAKE_NONCOPYABLE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -830 lines) Patch
M Source/core/core.gypi View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
D Source/core/platform/PlatformSpeechSynthesisUtterance.h View 1 chunk +0 lines, -89 lines 0 comments Download
D Source/core/platform/PlatformSpeechSynthesisUtterance.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/core/platform/PlatformSpeechSynthesisVoice.h View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/platform/PlatformSpeechSynthesisVoice.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/core/platform/PlatformSpeechSynthesizer.h View 1 chunk +0 lines, -90 lines 0 comments Download
D Source/core/platform/PlatformSpeechSynthesizer.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D Source/core/platform/chromium/support/WebSpeechSynthesisUtterance.cpp View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/core/platform/chromium/support/WebSpeechSynthesisVoice.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
D Source/core/platform/chromium/support/WebSpeechSynthesizerClientImpl.h View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/core/platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
M Source/core/platform/mock/PlatformSpeechSynthesizerMock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/mock/PlatformSpeechSynthesizerMock.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesis.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
A + Source/platform/exported/WebSpeechSynthesisUtterance.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/exported/WebSpeechSynthesisVoice.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/exported/WebSpeechSynthesizerClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/platform/speech/PlatformSpeechSynthesisUtterance.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
A + Source/platform/speech/PlatformSpeechSynthesisUtterance.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/speech/PlatformSpeechSynthesisVoice.h View 1 chunk +2 lines, -1 line 0 comments Download
A + Source/platform/speech/PlatformSpeechSynthesisVoice.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/speech/PlatformSpeechSynthesizer.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
A + Source/platform/speech/PlatformSpeechSynthesizer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M public/platform/WebSpeechSynthesisUtterance.h View 1 chunk +14 lines, -14 lines 0 comments Download
M public/platform/WebSpeechSynthesisVoice.h View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pilgrim_google
7 years ago (2013-12-09 16:03:22 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/110393002/diff/1/Source/platform/speech/PlatformSpeechSynthesisUtterance.h File Source/platform/speech/PlatformSpeechSynthesisUtterance.h (right): https://codereview.chromium.org/110393002/diff/1/Source/platform/speech/PlatformSpeechSynthesisUtterance.h#newcode37 Source/platform/speech/PlatformSpeechSynthesisUtterance.h:37: class PLATFORM_EXPORT PlatformSpeechSynthesisUtteranceClient { This class is entirely ...
7 years ago (2013-12-09 17:39:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/110393002/20001
7 years ago (2013-12-09 19:32:29 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=16454
7 years ago (2013-12-09 22:06:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/110393002/40001
7 years ago (2013-12-10 19:05:01 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-10 20:17:49 UTC) #6
Message was sent while issue was closed. 
Change committed as 163562

Powered by Google App Engine
This is Rietveld 408576698