Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: remoting/webapp/crd/js/server_log_entry.js

Issue 1103913002: Start logging host-version info in the Chromoting client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update function name to more closely match its purpose. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/log_to_server.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/server_log_entry.js
diff --git a/remoting/webapp/crd/js/server_log_entry.js b/remoting/webapp/crd/js/server_log_entry.js
index 00cab93871a5a41da92d66a67afec8e13e973d67..2b3b5acace2ffd2bb8ad0649decb8300e00f35ae 100644
--- a/remoting/webapp/crd/js/server_log_entry.js
+++ b/remoting/webapp/crd/js/server_log_entry.js
@@ -159,6 +159,9 @@ remoting.ServerLogEntry.KEY_BROWSER_VERSION_ = 'browser-version';
remoting.ServerLogEntry.KEY_WEBAPP_VERSION_ = 'webapp-version';
/** @private */
+remoting.ServerLogEntry.KEY_HOST_VERSION_ = 'host-version';
+
+/** @private */
remoting.ServerLogEntry.VALUE_EVENT_NAME_SESSION_ID_OLD_ = 'session-id-old';
/** @private */
@@ -367,7 +370,7 @@ remoting.ServerLogEntry.prototype.addSessionIdField = function(sessionId) {
/**
* Adds fields describing the host to this log entry.
*/
-remoting.ServerLogEntry.prototype.addHostFields = function() {
+remoting.ServerLogEntry.prototype.addClientOSFields = function() {
var host = remoting.ServerLogEntry.getHostData_();
if (host) {
if (host.os_name.length > 0) {
@@ -477,6 +480,15 @@ remoting.ServerLogEntry.prototype.addWebappVersionField = function() {
};
/**
+ * Adds a field specifying the host version to this log entry.
+ * @param {string} hostVersion Version of the host for current session.
+ * @return {void} Nothing.
+ */
+remoting.ServerLogEntry.prototype.addHostVersion = function(hostVersion) {
+ this.set_(remoting.ServerLogEntry.KEY_HOST_VERSION_, hostVersion);
+};
+
+/**
* Adds a field specifying the mode to this log entry.
*/
remoting.ServerLogEntry.prototype.addModeField = function() {
« no previous file with comments | « remoting/webapp/crd/js/log_to_server.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698