Start logging host-version info in the Chromoting client.

remoting/webapp/crd/js/server_log_entry.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * A class of server log entries.
  *
  * Any changes to the values here need to be coordinated with the host and
  * server/log proto code.
@@ skipping 141 matching lines @@
 /** @private */
 remoting.ServerLogEntry.KEY_CPU_ = 'cpu';
 
 /** @private */
 remoting.ServerLogEntry.KEY_BROWSER_VERSION_ = 'browser-version';
 
 /** @private */
 remoting.ServerLogEntry.KEY_WEBAPP_VERSION_ = 'webapp-version';
 
 /** @private */
+remoting.ServerLogEntry.KEY_HOST_VERSION_ = 'host-version';
+
+/** @private */
 remoting.ServerLogEntry.VALUE_EVENT_NAME_SESSION_ID_OLD_ = 'session-id-old';
 
 /** @private */
 remoting.ServerLogEntry.VALUE_EVENT_NAME_SESSION_ID_NEW_ = 'session-id-new';
 
 /** @private */
 remoting.ServerLogEntry.KEY_MODE_ = 'mode';
 /** @private */
 remoting.ServerLogEntry.VALUE_MODE_IT2ME_ = 'it2me';
 /** @private */
@@ skipping 188 matching lines @@
  *
  * @param {string} sessionId
  */
 remoting.ServerLogEntry.prototype.addSessionIdField = function(sessionId) {
   this.set_(remoting.ServerLogEntry.KEY_SESSION_ID_, sessionId);
 }
 
 /**
  * Adds fields describing the host to this log entry.
  */
 remoting.ServerLogEntry.prototype.addHostFields = function() {

[anandc, 2015/04/24 19:54:27]

This is actually information about the local host, because we are parsing the
user-agent to obtain this. See extractHostDataFrom_() below.
Is there a reason we are logging that, instead of the remote-host info? 

[Jamie, 2015/04/24 20:34:02]

The function is poorly-named. It should be called something like
addClientOsFields. Feel free to change it if you like.

[anandc, 2015/04/24 21:36:35]

Done.

   var host = remoting.ServerLogEntry.getHostData_();
   if (host) {
     if (host.os_name.length > 0) {
       this.set_(remoting.ServerLogEntry.KEY_OS_NAME_, host.os_name);
     }
     if (host.os_version.length > 0) {
       this.set_(remoting.ServerLogEntry.KEY_OS_VERSION_, host.os_version);
     }
     if (host.cpu.length > 0) {
       this.set_(remoting.ServerLogEntry.KEY_CPU_, host.cpu);
@@ skipping 89 matching lines @@
  * Adds a field specifying the webapp version to this log entry.
  */
 remoting.ServerLogEntry.prototype.addWebappVersionField = function() {
   var manifest = chrome.runtime.getManifest();
   if (manifest && manifest.version) {
     this.set_(remoting.ServerLogEntry.KEY_WEBAPP_VERSION_, manifest.version);
   }
 };
 
 /**
+ * Adds a field specifying the host version to this log entry.
+ * @param {string} hostVersion Version of the host for current session.
+ * @return {void} Nothing.
+ */
+remoting.ServerLogEntry.prototype.addHostVersion = function(hostVersion) {
+  this.set_(remoting.ServerLogEntry.KEY_HOST_VERSION_, hostVersion);
+};
+
+/**
  * Adds a field specifying the mode to this log entry.
  */
 remoting.ServerLogEntry.prototype.addModeField = function() {
   this.set_(remoting.ServerLogEntry.KEY_MODE_,
             remoting.ServerLogEntry.getModeField_());
 };
 
 /**
  * Gets the value of the mode field to be put in a log entry.
  *
  * @private
  * @return {string}
  */
 remoting.ServerLogEntry.getModeField_ = function() {
   switch(remoting.app.getConnectionMode()) {
     case remoting.Application.Mode.IT2ME:
       return remoting.ServerLogEntry.VALUE_MODE_IT2ME_;
     case remoting.Application.Mode.ME2ME:
       return remoting.ServerLogEntry.VALUE_MODE_ME2ME_;
     case remoting.Application.Mode.APP_REMOTING:
       return remoting.ServerLogEntry.VALUE_MODE_APP_REMOTING_;
     default:
       return remoting.ServerLogEntry.VALUE_MODE_UNKNOWN_;
   }
 };