Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1103883002: Convert Block code to layoutObject. (Closed)

Created:
5 years, 8 months ago by dsinclair
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Convert Block code to layoutObject. This CL updates the uses of renderer in the block code to be layoutObject. BUG=462960 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194428

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -86 lines) Patch
M Source/core/layout/LayoutBlock.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 15 chunks +23 lines, -23 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 7 chunks +16 lines, -16 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 1 22 chunks +34 lines, -34 lines 0 comments Download
M Source/core/layout/line/BreakingContextInlineHeaders.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/LineWidth.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/WordMeasurement.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL.
5 years, 8 months ago (2015-04-24 15:06:46 UTC) #2
leviw_travelin_and_unemployed
LGTM. Typo in description: "inte block code" https://codereview.chromium.org/1103883002/diff/1/Source/core/layout/LayoutBlock.h File Source/core/layout/LayoutBlock.h (right): https://codereview.chromium.org/1103883002/diff/1/Source/core/layout/LayoutBlock.h#newcode82 Source/core/layout/LayoutBlock.h:82: LayoutUnit minLineHeightForReplacedLayoutObject(bool ...
5 years, 8 months ago (2015-04-24 18:47:32 UTC) #3
dsinclair
https://codereview.chromium.org/1103883002/diff/1/Source/core/layout/LayoutBlock.h File Source/core/layout/LayoutBlock.h (right): https://codereview.chromium.org/1103883002/diff/1/Source/core/layout/LayoutBlock.h#newcode82 Source/core/layout/LayoutBlock.h:82: LayoutUnit minLineHeightForReplacedLayoutObject(bool isFirstLine, LayoutUnit replacedHeight) const; On 2015/04/24 at ...
5 years, 8 months ago (2015-04-25 00:53:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103883002/20001
5 years, 8 months ago (2015-04-25 00:54:01 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 02:11:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194428

Powered by Google App Engine
This is Rietveld 408576698