Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1103853004: scheduler: Encapsulate task queue selector inside the scheduler helper (Closed)

Created:
5 years, 8 months ago by Sami
Modified:
5 years, 8 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Encapsulate task queue selector inside the scheduler helper Encapsulate task queue selector inside the scheduler helper to avoid clients changing task queue states in an uncontrolled way. This will be needed by the upcoming shutdown task queue. No functional changes. BUG=463143 Committed: https://crrev.com/a08639cd15b52dfb784cc94295e9fc13823b1d71 Cr-Commit-Position: refs/heads/master@{#326833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -28 lines) Patch
M components/scheduler/child/scheduler_helper.h View 3 chunks +7 lines, -2 lines 0 comments Download
M components/scheduler/child/scheduler_helper.cc View 3 chunks +24 lines, -6 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 2 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sami
5 years, 8 months ago (2015-04-24 17:02:49 UTC) #2
rmcilroy
On 2015/04/24 17:02:49, Sami wrote: lgtm, thanks!
5 years, 8 months ago (2015-04-24 17:05:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103853004/1
5 years, 8 months ago (2015-04-24 17:10:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 17:59:38 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 18:00:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a08639cd15b52dfb784cc94295e9fc13823b1d71
Cr-Commit-Position: refs/heads/master@{#326833}

Powered by Google App Engine
This is Rietveld 408576698