Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1103843002: Preprocess structured stack trace on GC to get rid of code reference. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
CC:
v8-dev, alph
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Preprocess structured stack trace on GC to get rid of code reference. R=verwaest@chromium.org BUG=v8:2340 LOG=N Committed: https://crrev.com/462ffa1dfa0ab3a851ea0294470d1ed7ed12dd56 Cr-Commit-Position: refs/heads/master@{#28085}

Patch Set 1 #

Patch Set 2 : move to mark compact epilogue #

Patch Set 3 : fix win #

Patch Set 4 : fix crash #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -5 lines) Patch
M src/factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 3 4 chunks +25 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M src/messages.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (13 generated)
Yang
5 years, 8 months ago (2015-04-24 10:03:59 UTC) #1
Yang
On 2015/04/24 10:03:59, Yang wrote: Preprocessing happens in mark-compact epilogue so that it's not done ...
5 years, 8 months ago (2015-04-24 10:23:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103843002/20001
5 years, 8 months ago (2015-04-24 10:25:33 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/2120)
5 years, 8 months ago (2015-04-24 10:36:36 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103843002/20001
5 years, 8 months ago (2015-04-24 12:41:18 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/2135)
5 years, 8 months ago (2015-04-24 12:52:45 UTC) #10
Toon Verwaest
lgtm. hpayer: does the GC part seem reasonable to you?
5 years, 8 months ago (2015-04-24 18:36:50 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103843002/40001
5 years, 8 months ago (2015-04-24 20:54:48 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/2147)
5 years, 8 months ago (2015-04-24 21:08:41 UTC) #16
Hannes Payer (out of office)
LGTM, but you have some try bots failing
5 years, 8 months ago (2015-04-27 08:07:00 UTC) #17
Yang
On 2015/04/27 08:07:00, Hannes Payer wrote: > LGTM, but you have some try bots failing ...
5 years, 8 months ago (2015-04-27 11:35:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103843002/60001
5 years, 8 months ago (2015-04-27 13:15:23 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/5189)
5 years, 8 months ago (2015-04-27 13:16:27 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103843002/80001
5 years, 8 months ago (2015-04-27 14:16:02 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-27 14:51:08 UTC) #27
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/462ffa1dfa0ab3a851ea0294470d1ed7ed12dd56 Cr-Commit-Position: refs/heads/master@{#28085}
5 years, 8 months ago (2015-04-27 14:51:23 UTC) #28
yurys
Looks like heap profiler needs update to treat references from weak_stack_trace_list (or probabli WeakFixedArray in ...
5 years, 8 months ago (2015-04-27 15:18:13 UTC) #30
Dmitry Lomov (no reviews)
5 years, 8 months ago (2015-04-27 15:53:22 UTC) #31
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1102383002/ by dslomov@chromium.org.

The reason for reverting is: Broke GCStress.

Powered by Google App Engine
This is Rietveld 408576698