Issue 110383002: Throw DOM exception in insertAdjacentHTML if context becomes null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110383002: Throw DOM exception in insertAdjacentHTML if context becomes null (Closed)

Created:
7 years ago by davve

Modified:
7 years ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Throw DOM exception in insertAdjacentHTML if context becomes null Align first part of the insertAdjacentHTML implementation with http://domparsing.spec.whatwg.org/#insertadjacenthtml(). "Let context be the context object's parent. If context is null or a document, throw a DOMException with name NoModificationAllowedError and terminate these steps." While the 'or a document' part was previously implemented, the 'context is null' part was not. BUG=326965 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163452

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -8 lines)			Patch
M	LayoutTests/fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLElement/script-tests/insertAdjacentHTML-errors.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dynamic/insertAdjacentHTML.html	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dynamic/insertAdjacentHTML-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/HTMLElement.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/110383002/1

7 years ago (2013-12-09 17:40:56 UTC) #3

Message was sent while issue was closed.

Change committed as 163452

Expand Messages | Collapse Messages