Issue 11038029: Add adb start-server on android buildbots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11038029: Add adb start-server on android buildbots (Closed)

Created:
8 years, 2 months ago by Isaac (away)

Modified:
8 years, 2 months ago

Reviewers:
navabi1, Yaron

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add adb start-server on android buildbots We think adb devices isn't giving full list when adb devices is called and daemon is not running. Manually start the adb daemon before the download/build steps. TBR=yaron BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160164

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/android/buildbot/buildbot_functions.sh	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yaron

https://chromiumcodereview.appspot.com/11038029/diff/1/build/android/buildbot/buildbot_functions.sh File build/android/buildbot/buildbot_functions.sh (right): https://chromiumcodereview.appspot.com/11038029/diff/1/build/android/buildbot/buildbot_functions.sh#newcode71 build/android/buildbot/buildbot_functions.sh:71: adb kill-server This is synchronous, right? We don't need ...

8 years, 2 months ago (2012-10-04 22:41:46 UTC) #3

Isaac (away)

8 years, 2 months ago (2012-10-05 19:33:58 UTC) #4

https://chromiumcodereview.appspot.com/11038029/diff/1/build/android/buildbot...
File build/android/buildbot/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/11038029/diff/1/build/android/buildbot...
build/android/buildbot/buildbot_functions.sh:71: adb kill-server
On 2012/10/04 22:41:46, Yaron wrote:
> This is synchronous, right? We don't need to give it time to settle down?

We do, but baseline_setup is run a couple minutes before the testing code
starts.  I will clean this up once I write a python run_tests wrapper. (i.e.
these calls will be put into the wrapper)

Expand Messages | Collapse Messages