- WeakProperty keys in other generations are black. Avoid trying to

vm/gc_marker.cc

Index: vm/gc_marker.cc
===================================================================
--- vm/gc_marker.cc	(revision 13085)
+++ vm/gc_marker.cc	(working copy)
@@ -368,7 +368,9 @@
                                    MarkingVisitor* visitor) {
   // The fate of the weak property is determined by its key.
   RawObject* raw_key = raw_weak->ptr()->key_;
-  if (!raw_key->IsMarked()) {
+  if (raw_key->IsHeapObject() &&

[cshapiro, 2012/10/01 22:22:14]

Can we use IsUnreachable instead of the explicit conjunction?  The null check
inside IsUnreachable should be unnecessary now that the null object is
pre-marked.

[Ivan Posva, 2012/10/01 22:27:39]

Different CL.

+      raw_key->IsOldObject() &&
+      !raw_key->IsMarked()) {
     // Key is white.  Delay the weak property.
     visitor->DelayWeakProperty(raw_weak);
   } else {