Make unused InitializeUnsafe private and rename to DoInitialize.

Make unused InitializeUnsafe private and rename to DoInitialize.

R=thestig@chromium.org
BUG=none
TEST=no unsafe way to use base::File

Committed: https://crrev.com/492cd47d8927756efa57d58b005da3c7636aeb1b
Cr-Commit-Position: refs/heads/master@{#326714}

[Dan Beam, 2015-04-23 17:04:07]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2015-04-23 20:53:24]

https://codereview.chromium.org/1103733002/diff/40001/base/files/file_win.cc
File base/files/file_win.cc (left):

https://codereview.chromium.org/1103733002/diff/40001/base/files/file_win.cc#...
base/files/file_win.cc:21: void File::InitializeUnsafe(const FilePath& name,
uint32 flags) {
Just change the method name and don't reorder the methods?

[Dan Beam, 2015-04-23 21:04:11]

https://codereview.chromium.org/1103733002/diff/40001/base/files/file_win.cc
File base/files/file_win.cc (left):

https://codereview.chromium.org/1103733002/diff/40001/base/files/file_win.cc#...
base/files/file_win.cc:21: void File::InitializeUnsafe(const FilePath& name,
uint32 flags) {
On 2015/04/23 20:53:24, Lei Zhang wrote:
> Just change the method name and don't reorder the methods?

the .h order wouldn't match the .cc.

[Lei Zhang, 2015-04-23 21:10:43]

lgtm

https://codereview.chromium.org/1103733002/diff/40001/base/files/file_win.cc
File base/files/file_win.cc (left):

https://codereview.chromium.org/1103733002/diff/40001/base/files/file_win.cc#...
base/files/file_win.cc:21: void File::InitializeUnsafe(const FilePath& name,
uint32 flags) {
On 2015/04/23 21:04:11, Dan Beam wrote:
> On 2015/04/23 20:53:24, Lei Zhang wrote:
> > Just change the method name and don't reorder the methods?
> 
> the .h order wouldn't match the .cc.

If you don't mind being git blamed for all this code.

[Dan Beam, 2015-04-23 21:16:01]

On 2015/04/23 21:10:43, Lei Zhang wrote:
> lgtm
> 
> https://codereview.chromium.org/1103733002/diff/40001/base/files/file_win.cc
> File base/files/file_win.cc (left):
> 
>
https://codereview.chromium.org/1103733002/diff/40001/base/files/file_win.cc#...
> base/files/file_win.cc:21: void File::InitializeUnsafe(const FilePath& name,
> uint32 flags) {
> On 2015/04/23 21:04:11, Dan Beam wrote:
> > On 2015/04/23 20:53:24, Lei Zhang wrote:
> > > Just change the method name and don't reorder the methods?
> > 
> > the .h order wouldn't match the .cc.
> 
> If you don't mind being git blamed for all this code.

i'll just defer to rvargas@ for most of it anyways...

[Dan Beam, 2015-04-23 21:44:30]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-04-23 21:45:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1103733002/40001

[commit-bot: I haz the power, 2015-04-24 01:28:03]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-04-24 01:28:56]

Patchset 2 (id:??) landed as
https://crrev.com/492cd47d8927756efa57d58b005da3c7636aeb1b
Cr-Commit-Position: refs/heads/master@{#326714}