Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/signin/signin_manager.cc

Issue 110373007: Delay loading the NTP after sign in until MergeSession has been performed in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_manager.cc
diff --git a/chrome/browser/signin/signin_manager.cc b/chrome/browser/signin/signin_manager.cc
index 72e446c389ff40321df0abcc95603c3fe3ac48aa..3cf6fcf2c81b88934433a862d52ad806852bafd0 100644
--- a/chrome/browser/signin/signin_manager.cc
+++ b/chrome/browser/signin/signin_manager.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/profiles/profile_io_data.h"
#include "chrome/browser/signin/about_signin_internals.h"
#include "chrome/browser/signin/about_signin_internals_factory.h"
+#include "chrome/browser/signin/google_auto_login_helper.h"
#include "chrome/browser/signin/local_auth.h"
#include "chrome/browser/signin/profile_oauth2_token_service.h"
#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
@@ -563,6 +564,14 @@ void SigninManager::CompletePendingSignin() {
token_service->UpdateCredentials(GetAuthenticatedUsername(),
temp_oauth_login_tokens_.refresh_token);
temp_oauth_login_tokens_ = ClientOAuthResult();
+
+ // If inline sign in is enabled, but new profile manage is not, perform a
+ // merge session now to push the user's credentials into the cookie jar.
+ if (!switches::IsNewProfileManagement() && switches::IsEnableInlineSignin()) {
+ // The helper deletes itself when done.
+ GoogleAutoLoginHelper* helper = new GoogleAutoLoginHelper(profile_);
+ helper->LogIn();
+ }
}
void SigninManager::OnExternalSigninCompleted(const std::string& username) {

Powered by Google App Engine
This is Rietveld 408576698